Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RID-specific app breaking change #34497

Merged
merged 3 commits into from
Mar 13, 2023
Merged

RID-specific app breaking change #34497

merged 3 commits into from
Mar 13, 2023

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Mar 10, 2023 •
edited by github-actions bot
Loading

Fixes #33726

Internal previews

📄 File(s) 🔗 Preview link(s)
docs/core/compatibility/8.0.md Preview: docs/core/compatibility/8.0
docs/core/compatibility/sdk/8.0/runtimespecific-app-default.md Preview: docs/core/compatibility/sdk/8.0/runtimespecific-app-default

@dotnet-bot dotnet-bot added this to the March 2023 milestone Mar 10, 2023
@ghost ghost added the 🏁 Release: .NET 8 Work items for the .NET 8 release label Mar 10, 2023
IEvangelist
IEvangelist approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, otherwise it looks great.

@gewarren @IEvangelist
Apply suggestions from code review
3847c0b 
Co-authored-by: David Pine <david.pine@microsoft.com>
@gewarren
Copy link
Contributor Author

Thanks @IEvangelist. Love the preview table too!!

@gewarren gewarren enabled auto-merge (squash) March 13, 2023 20:00
@gewarren gewarren merged commit 37aab50 into dotnet:main Mar 13, 2023
@gewarren gewarren deleted the selfcontained-default branch March 13, 2023 20:05
gewarren added a commit that referenced this pull request Mar 13, 2023
@gewarren
Revert "RID-specific app breaking change (#34497)"
7d0c5db 
This reverts commit 37aab50.
@gewarren gewarren mentioned this pull request Mar 13, 2023
Merged
gewarren added a commit that referenced this pull request Mar 13, 2023
@gewarren
Revert "RID-specific app breaking change (#34497)" (#34541)
e81ca27 
This reverts commit 37aab50.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

Assignees
No one assigned
Labels
🏁 Release: .NET 8 Work items for the .NET 8 release dotnet-fundamentals/svc
Projects
No open projects
.NET 8.0 work items
Status: ✅ Done
Milestone
March 2023
3 participants
@gewarren @IEvangelist @dotnet-bot