CC6494: Update interpolated-strings.md #41 [AUTOMATED] #3456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, @BillWagner, This proposed file change comes from: https://github.com/dotnet/docs.ko-kr/pull/41/files. Could you help to review this and merge this? Many thanks in advance.
|
Thanks, @carolinacmoravia. If you've made this change in one or more localized versions, there's an additional change that needs to be made. In the description of the variables on line 22, |
rpetrusha
approved these changes
Oct 18, 2017
BillWagner
requested changes
Oct 18, 2017
| @@ -17,12 +17,12 @@ Used to construct strings. An interpolated string looks like a template string | |||
| The arguments of an interpolated string are easier to understand than a [composite format string](../../../standard/base-types/composite-formatting.md#composite-format-string). For example, the interpolated string | |||
|
|
|||
| ```csharp | |||
| Console.WriteLine($"Name = {name}, hours = {date:hh}"); | |||
| Console.WriteLine($"Name = {name}, hours = {hours}:hh"); | |||
There was a problem hiding this comment.
This change introduced a coding error:
{hours}:hhshould be:
{hours:hh}Otherwise, the variable won't be formatted correclty.
|
|
||
| ```csharp | ||
| Console.WriteLine("Name = {0}, hours = {1:hh}", name, date); | ||
| Console.WriteLine("Name = {0}, hours = {1}:hh", name, hours); |
There was a problem hiding this comment.
Same comment as above. This should be:
{1:hh}
|
I've addressed your feedback @BillWagner. Take a look! |
BillWagner
approved these changes
Oct 19, 2017
|
Thanks @mairaw This is ready to |
when the build finishes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @BillWagner,
This proposed file change comes from: https://github.com/dotnet/docs.ko-kr/pull/41/files.
Could you help to review this and merge this?
Many thanks in advance.