Skip to content

Fix invalid regular expression #3467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2017
Merged

Fix invalid regular expression #3467

merged 1 commit into from
Oct 19, 2017

Conversation

jeppert
Copy link
Contributor

@jeppert jeppert commented Oct 19, 2017

Updated regular expression matching invalid domain names

Regular expression used \w in the part the matches the domain. A word (\w) matches with '_' which is an invalid character in a domain name.

Summary

The second part of the regular expression matched for underscore, an invalid character in a domain name. Updated the regular expression and the descriptive text to simply match for alpha numeric characters.

Regular expression used \w in the part the matches the domain. A word (\w) matches with '_' which is an invalid character in a domain name.
@dnfclas
Copy link

dnfclas commented Oct 19, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@rpetrusha rpetrusha added the ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository label Oct 19, 2017
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to the dotnet/docs repo and improving this regex, @jeppert. We'll merge your PR now. Changes should appear on docs.microsoft.com in the next day or two.

@rpetrusha rpetrusha merged commit 5596e85 into dotnet:master Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants