Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BinaryFormatter disabled & obsoletion of legacy serialization APIs #35217

Merged
merged 16 commits into from
May 16, 2023
Merged

BinaryFormatter disabled & obsoletion of legacy serialization APIs #35217

merged 16 commits into from
May 16, 2023

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented May 2, 2023 •
edited by github-actions bot
Loading

Fixes #34891
Fixes #34893

📄 File 🔗 Preview link
docs/core/compatibility/core-libraries/8.0/obsolete-apis-with-custom-diagnostics.md Obsolete APIs with custom diagnostics - .NET 8
docs/core/compatibility/serialization/8.0/binaryformatter-disabled.md BinaryFormatter is disabled
docs/fundamentals/syslib-diagnostics/syslib0011.md SYSLIB0011: BinaryFormatter serialization is obsolete
docs/fundamentals/syslib-diagnostics/syslib0050.md SYSLIB0050
docs/fundamentals/syslib-diagnostics/syslib0051.md SYSLIB0051

Internal previews

Toggle expand/collapse
📄 File 🔗 Preview link
docs/core/compatibility/5.0.md Breaking changes in .NET 5
docs/core/compatibility/7.0.md Breaking changes in .NET 7
docs/core/compatibility/8.0.md docs/core/compatibility/8.0
docs/core/compatibility/core-libraries/8.0/obsolete-apis-with-custom-diagnostics.md docs/core/compatibility/core-libraries/8.0/obsolete-apis-with-custom-diagnostics
docs/core/compatibility/serialization/5.0/binaryformatter-serialization-obsolete.md docs/core/compatibility/serialization/5.0/binaryformatter-serialization-obsolete
docs/core/compatibility/serialization/7.0/binaryformatter-apis-produce-errors.md docs/core/compatibility/serialization/7.0/binaryformatter-apis-produce-errors
docs/core/compatibility/serialization/7.0/serializationformat-binary.md docs/core/compatibility/serialization/7.0/serializationformat-binary
docs/core/compatibility/serialization/8.0/binaryformatter-disabled.md docs/core/compatibility/serialization/8.0/binaryformatter-disabled
docs/core/compatibility/unsupported-apis.md APIs that always throw exceptions on .NET Core and .NET 5+
docs/core/deploying/trimming/trimming-options.md Trimming options
docs/fundamentals/syslib-diagnostics/obsoletions-overview.md docs/fundamentals/syslib-diagnostics/obsoletions-overview
docs/fundamentals/syslib-diagnostics/syslib0011.md SYSLIB0011: BinaryFormatter serialization is obsolete
docs/fundamentals/syslib-diagnostics/syslib0038.md SYSLIB0038: SerializationFormat.Binary is obsolete
docs/fundamentals/syslib-diagnostics/syslib0050.md docs/fundamentals/syslib-diagnostics/syslib0050
docs/fundamentals/syslib-diagnostics/syslib0051.md docs/fundamentals/syslib-diagnostics/syslib0051

@gewarren gewarren requested review from adegeo and a team as code owners May 2, 2023 02:57
@dotnet-bot dotnet-bot added this to the May 2023 milestone May 2, 2023
@ghost ghost added the 🏁 Release: .NET 8 Work items for the .NET 8 release label May 2, 2023
@gewarren gewarren changed the title BinaryFormatter disabled - breaking change BinaryFormatter disabled & obsoletion of legacy serialization APIs May 9, 2023
BillWagner
BillWagner approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all LGTM @gewarren

You can :shipit: when ready.

@gewarren gewarren merged commit f897d9e into dotnet:main May 16, 2023
@gewarren gewarren deleted the bfpre4 branch May 16, 2023 20:31
@gewarren
Copy link
Contributor Author

Thanks so much @BillWagner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@adegeo adegeo Awaiting requested review from adegeo adegeo is a code owner

@GrabYourPitchforks GrabYourPitchforks Awaiting requested review from GrabYourPitchforks

Assignees
No one assigned
Labels
🏁 Release: .NET 8 Work items for the .NET 8 release dotnet-fundamentals/svc
Projects
No open projects
.NET 8.0 work items
Status: ✅ Done
Milestone
May 2023
4 participants
@gewarren @BillWagner @GrabYourPitchforks @dotnet-bot