Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK/MSBuild breaking changes for RC 1 #36977

Merged
merged 4 commits into from
Sep 6, 2023
Merged

SDK/MSBuild breaking changes for RC 1 #36977

merged 4 commits into from
Sep 6, 2023

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Sep 5, 2023 •
edited
Loading

Fixes #36527
Fixes #35480
Fixes #35267 (removes breaking change article since the change was reverted in RC 1)
Contributes to #36403

Internal previews

📄 File 🔗 Preview link
docs/core/compatibility/8.0.md Breaking changes in .NET 8
docs/core/compatibility/deployment/8.0/rid-asset-list.md Host determines RID-specific assets
docs/core/compatibility/sdk/8.0/custombuildeventargs.md "Breaking change: MSBuild custom derived build events deprecated"
docs/core/compatibility/sdk/8.0/rid-graph.md .NET SDK uses a smaller RID graph
docs/core/compatibility/sdk/8.0/trimming-unsupported-targetframework.md Trimming may not be used with .NET Standard or .NET Framework
docs/core/compatibility/sdk/8.0/version-requirements.md docs/core/compatibility/sdk/8.0/version-requirements
docs/whats-new/dotnet-docs-mod0.md .NET docs: What's new for June 2023

@gewarren gewarren requested review from BillWagner and a team as code owners September 5, 2023 23:53
@dotnet-bot dotnet-bot added this to the September 2023 milestone Sep 5, 2023
@ghost ghost added the 🏁 Release: .NET 8 Work items for the .NET 8 release label Sep 5, 2023
BillWagner
BillWagner approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all LGTM @gewarren

Let's :shipit:

@gewarren gewarren merged commit 6bec746 into dotnet:main Sep 6, 2023
@gewarren gewarren deleted the sdk-changes branch September 6, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@JanKrivanek JanKrivanek Awaiting requested review from JanKrivanek

@marcpopMSFT marcpopMSFT Awaiting requested review from marcpopMSFT

@elinor-fung elinor-fung Awaiting requested review from elinor-fung

@JL03-Yue JL03-Yue Awaiting requested review from JL03-Yue

@rainersigwald rainersigwald Awaiting requested review from rainersigwald

@rokonec rokonec Awaiting requested review from rokonec

Assignees
No one assigned
Labels
🏁 Release: .NET 8 Work items for the .NET 8 release dotnet-fundamentals/svc
Projects
No open projects
.NET 8.0 work items
Status: ✅ Done
Milestone
September 2023
3 participants
@gewarren @BillWagner @dotnet-bot