Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remaining STJ work for .NET 8 #37806

Merged
merged 8 commits into from
Oct 31, 2023
Merged

Remaining STJ work for .NET 8 #37806

merged 8 commits into from
Oct 31, 2023

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Oct 31, 2023 •
edited by github-actions bot
Loading

Fixes #37101.

Adds section on disabling reflection defaults.

Splits the source generation modes article into two separate articles:

  1. Choose reflection vs. source generation.
  2. Source generation modes.

Internal previews

📄 File 🔗 Preview link
docs/core/whats-new/dotnet-8.md What's new in .NET 8
docs/standard/serialization/system-text-json/customize-properties.md How to customize property names and values with System.Text.Json
docs/standard/serialization/system-text-json/overview.md "Serialize and deserialize JSON using C# - .NET"
docs/standard/serialization/system-text-json/populate-properties.md Populate initialized properties
docs/standard/serialization/system-text-json/reflection-vs-source-generation.md docs/standard/serialization/system-text-json/reflection-vs-source-generation
docs/standard/serialization/system-text-json/required-properties.md Required properties
docs/standard/serialization/system-text-json/source-generation-modes.md Source-generation modes in System.Text.Json
docs/standard/serialization/system-text-json/source-generation.md How to use source generation in System.Text.Json

@gewarren gewarren requested a review from a team as a code owner October 31, 2023 00:11
@dotnet-bot dotnet-bot added this to the October 2023 milestone Oct 31, 2023
@ghost ghost added the 🏁 Release: .NET 8 Work items for the .NET 8 release label Oct 31, 2023
IEvangelist
IEvangelist approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, :shipit: when you're ready. Just a few suggestions.

docs/standard/serialization/system-text-json/reflection-vs-source-generation.md Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json/reflection-vs-source-generation.md Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json/reflection-vs-source-generation.md Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json/source-generation.md Show resolved Hide resolved
docs/standard/serialization/system-text-json/source-generation.md Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json/source-generation.md Show resolved Hide resolved
gewarren and others added 3 commits October 30, 2023 18:54
@gewarren @IEvangelist
Apply suggestions from code review
9fe29f3 
Co-authored-by: David Pine <david.pine@microsoft.com>
@gewarren
tweaks
19e6f39
@gewarren
fix warnings
b9b534d
gewarren and others added 3 commits October 31, 2023 11:27
@gewarren @eiriktsarpalis
Apply suggestions from code review
1e44f99 
Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
@gewarren
respond to feedback
fc50544
@gewarren
resolve conflicts
289d552
@gewarren gewarren merged commit 6a624eb into dotnet:main Oct 31, 2023
8 checks passed
@gewarren gewarren deleted the sourcegenmodes branch October 31, 2023 19:24
@gewarren
Copy link
Contributor Author

Thanks for reviewing @eiriktsarpalis and @IEvangelist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis left review comments

@IEvangelist IEvangelist IEvangelist approved these changes

Assignees
No one assigned
Labels
🏁 Release: .NET 8 Work items for the .NET 8 release dotnet-fundamentals/svc
Projects
No open projects
.NET 8.0 work items
Status: ✅ Done
Milestone
October 2023
Development

Successfully merging this pull request may close these issues.

Create/Update conceptual docs for new System.Text.Json features in .NET 8
4 participants
@gewarren @eiriktsarpalis @IEvangelist @dotnet-bot