-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating ref docs to include the metrics bucket information for connection histograms #37811
Conversation
Adding link to JamesNK's similar change to the OTel docs: open-telemetry/semantic-conventions#283 (review) |
I think this level of detail is unnecessary in the .NET docs. Most people won't know what histogram buckets are. The people who do care can look at the spec in the OTEL repo for more information. |
Updated to square brackets to be in sync with the OTel docs.
I said this wasn’t necessary? |
@IEvangelist Revert? |
@gewarren - I guess, I also don't think it hurts to have it. It seems valuable, I'd personally rather read this alongside the .NET bits that discuss this sort of thing, and I would likely avoid reading the OTEL spec. That's why I merged it... Y'all can revert it if you think it's really that unnecessary, otherwise leave it. 🤷🏼♂️ |
Summary
We default histogram buckets to a size that makes sense for requests, but is not ideal for connections. This change provides longer durations for connections so that the upper bound is 5min. Connections may last longer than that, but the performance difference will be negligible after 10s of seconds, so seems like a good upper bound, while still providing granularity at the lower values, and using an approximate doubling of each bucket size.
Related to open-telemetry/opentelemetry-dotnet#5008,
open-telemetry/opentelemetry-dotnet#4922
Internal previews