Skip to content

Add, update compiler error and warning messages for ref struct interfaces #41948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

BillWagner
Copy link
Member

@BillWagner BillWagner commented Jul 30, 2024

Add pages and F1 targets for new compiler error and warning messages related to ref struct types implementing interfaces.

Fixes #41206

Commit by commit log for reviewers:

  1. The PR for ref struct interfaces added new compiler error and warning messages. It also updates a few messages. This commit creates the stubs for the new messages, and updates the text for updated messages.
  2. Incorporate additional ref struct related errors and warnings (including those previously undocumented.)
  3. Edit pass.

Internal previews

📄 File 🔗 Preview link
docs/csharp/language-reference/compiler-messages/feature-version-errors.md Resolve warnings related to language features and versions
docs/csharp/language-reference/compiler-messages/ref-modifiers-errors.md Errors and warnings associated with reference parameter modifiers
docs/csharp/language-reference/compiler-messages/ref-struct-errors.md Errors and warnings associated with ref struct types
docs/csharp/language-reference/keywords/ref.md docs/csharp/language-reference/keywords/ref
docs/csharp/misc/cs0401.md Compiler Error CS0401
docs/csharp/misc/sorry-we-don-t-have-specifics-on-this-csharp-error.md Sorry, we don't have specifics on this C# error

@BillWagner BillWagner force-pushed the interface-refs-errors-warnings branch from 42bbd9e to 4208709 Compare July 30, 2024 15:34
@BillWagner BillWagner marked this pull request as ready for review July 30, 2024 19:53
@BillWagner BillWagner requested a review from a team as a code owner July 30, 2024 19:53
@BillWagner BillWagner requested a review from adegeo July 30, 2024 19:53
@BillWagner
Copy link
Member Author

/cc @adegeo for review

The PR for `ref struct` interfaces added new compiler error and warning messages. It also updates a few messages. This commit creates the stubs for the new messages, and updates the text for updated messages.
@BillWagner BillWagner force-pushed the interface-refs-errors-warnings branch from 5543086 to 551f673 Compare July 31, 2024 01:08
@BillWagner BillWagner closed this Jul 31, 2024
@BillWagner BillWagner reopened this Jul 31, 2024
Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BillWagner BillWagner merged commit a4fa2cd into dotnet:main Jul 31, 2024
16 checks passed
@dotnet-policy-service dotnet-policy-service bot added the 🏁 Release: .NET 9 Work items for the .NET 9 release label Jul 31, 2024
@BillWagner BillWagner deleted the interface-refs-errors-warnings branch July 31, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C# 13]: New Feature - ref struct interfaces
3 participants