Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flag #4218

Merged
merged 1 commit into from
Jan 26, 2018
Merged

Fix flag #4218

merged 1 commit into from
Jan 26, 2018

Conversation

hvanbakel
Copy link
Contributor

Fix additional-deps as it is WITH a dash as opposed to additionalprobingpath

Title

Additional dependencies are set with --addtional-deps which is inconsitent with --additionalprobingpath but that's how the current code is.

Fix additional-deps as it is WITH a dash as opposed to additionalprobingpath
@JRAlexander JRAlexander added the ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository label Jan 26, 2018
Copy link
Contributor

@JRAlexander JRAlexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch, @hvanbakel! Thanks for your contribution! I'll get this merged straightaway, and you should see it live with in the next couple of days.

@JRAlexander JRAlexander merged commit 5f4ce40 into dotnet:master Jan 26, 2018
This was referenced Dec 3, 2024
This was referenced Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants