Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IsApproximatelyEqual sample for negative values #43345

Merged
merged 4 commits into from
Apr 1, 2025

Conversation

cycopepe
Copy link
Contributor

@cycopepe cycopepe commented Nov 5, 2024

Fix IsApproximatelyEqual sample for negative values

Example for runtime-library/system-single related to IsApproximatelyEqual is wrong for negative values. see published page here

Changes includes fixed on IsApproximatelyEqual methods and adding example case using negative values

Fixes 9173

@cycopepe cycopepe requested a review from a team as a code owner November 5, 2024 19:16
@dotnetrepoman dotnetrepoman bot added this to the November 2024 milestone Nov 5, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Nov 5, 2024
@cycopepe cycopepe changed the title Fix IsApproximatelyEqual sample for negative values #9173 Fix IsApproximatelyEqual sample for negative values Nov 5, 2024
@cycopepe
Copy link
Contributor Author

cycopepe commented Nov 7, 2024

#sign-off

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cycopepe

@gewarren gewarren enabled auto-merge (squash) April 1, 2025 21:41
@gewarren gewarren merged commit 4293864 into dotnet:main Apr 1, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example IsApproximatelyEqual has a bug when using negative numbers
3 participants