Skip to content

SFI Wave 4 Remediation #45029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2025
Merged

SFI Wave 4 Remediation #45029

merged 3 commits into from
Feb 28, 2025

Conversation

v-albemi
Copy link
Contributor

@v-albemi v-albemi commented Feb 25, 2025

Summary

Hi Tom,

The Aquent Q&M team is assisting in remediation of flagged issues from the most recent SFI scan. Please review the changes in this PR and either approve and merge or request an alternative change that will meet current guidance.

@v-albemi v-albemi requested review from tommcdon and a team as code owners February 25, 2025 23:13
@dotnetrepoman dotnetrepoman bot added this to the February 2025 milestone Feb 25, 2025
@v-albemi v-albemi marked this pull request as draft February 25, 2025 23:13
@dotnet-policy-service dotnet-policy-service bot added dotnet-fundamentals/svc community-contribution Indicates PR is created by someone from the .NET community. labels Feb 25, 2025
@v-albemi v-albemi marked this pull request as ready for review February 25, 2025 23:45
@v-albemi
Copy link
Contributor Author

@tommcdon, this is ready for your review. Thanks!

@gewarren gewarren requested a review from IEvangelist February 26, 2025 00:34
BillWagner
BillWagner previously approved these changes Feb 26, 2025
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @v-albemi

You need to fix the build warning on the deleted image file before we can merge this.

@BillWagner BillWagner dismissed their stale review February 26, 2025 12:41

There need to be changes to fix the build warning.

@v-albemi v-albemi marked this pull request as draft February 26, 2025 16:52
@v-albemi v-albemi marked this pull request as ready for review February 26, 2025 17:19
@v-albemi
Copy link
Contributor Author

@BillWagner, I have resolved the build warning. Thanks!

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @v-albemi

This looks great, and I'll :shipit: now.

@BillWagner BillWagner merged commit 800190c into dotnet:main Feb 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants