-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #45152 #45168
base: main
Are you sure you want to change the base?
Fix for #45152 #45168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the submission, however, the bug indicates that the diagram is also wrong. So we need that fixed along with the text. I checked the article and the diagram does indeed reference ILight.PowerStatus
instead of ILight.Power()
.
@adegeo woops! sorry about that, i'll get this fixed and file a new PR later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @samwherever
This looks great, and I'll now.
@adegeo, @BillWagner - when i try to open the SVG in illustrator, i get a notification saying "Clipping will be lost on roundtrip to Tiny" and the text isn't appearing. i can recreate the SVG from scratch if you want, but i wanted to ask beforehand. |
I don't what was used to create it, I've only used InkScape as it's free all around. (To clarify, I didn't make the image) |
@adegeo heyo! i tried updating the diagram via illustrator - let me know if it looks alright. sorry for the delay on this! |
@samwherever Hi! Sorry for MY delay this time! I was out sick with a bad flu. Thanks for fixing the diagram! The preview page renders the diagram very small. I'm unsure why, as I'm not too familiar with SVG. Looking at the github diff, you can see that there's an artificial width on the SVG some how compared to the old one: Poking into the XML I see that it has a viewbox set like so: <svg ... viewBox="0 0 1920 382"> Maybe set the viewbox width to something smaller? Perhaps half the amount of the height? I did a quick search and you can use % values. Perhaps 25% of width and 100% for height? I wonder if that would let it zoom well enough? Or still try some hardcoded values. <svg ... viewBox="0 0 25% 100%"> |
heyo @adegeo, welcome back and i hope you're feeling better. if it's not compulsory to use SVG, i can easily just make this a jpeg/png and hardcode the sizing values. that alright? |
Summary
Fix applied as described in the issue.
Fixes #45152
Internal previews