Use interpolated strings (fundamentals/runtime-libraries chunk one) #45453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
approved these changes
Mar 21, 2025
There was a problem hiding this comment.
This looks great @gewarren
I had a number of minor / nit suggestions to look at. The path and raw string literals are more important than the newline ones. Once you decide what to do, go ahead and ship it.
docs/fundamentals/runtime-libraries/snippets/System/Boolean/Overview/csharp/binary1.cs
Outdated
Show resolved
Hide resolved
docs/fundamentals/runtime-libraries/snippets/System/Double/CompareTo/csharp/compareto2.cs
Outdated
Show resolved
Hide resolved
docs/fundamentals/runtime-libraries/snippets/System/Double/CompareTo/csharp/compareto3.cs
Outdated
Show resolved
Hide resolved
docs/fundamentals/runtime-libraries/snippets/System/Double/Overview/csharp/Program.cs
Show resolved
Hide resolved
docs/fundamentals/runtime-libraries/snippets/System/Double/Overview/csharp/comparison2.cs
Outdated
Show resolved
Hide resolved
docs/fundamentals/runtime-libraries/snippets/System/Single/Overview/csharp/exceptional2.cs
Outdated
Show resolved
Hide resolved
docs/fundamentals/runtime-libraries/snippets/System/Single/Overview/csharp/precisionlist4a.cs
Outdated
Show resolved
Hide resolved
docs/fundamentals/runtime-libraries/snippets/System/Single/Overview/csharp/precisionlist4a.cs
Outdated
Show resolved
Hide resolved
docs/fundamentals/runtime-libraries/snippets/System/String/Overview/csharp/index11.cs
Outdated
Show resolved
Hide resolved
docs/fundamentals/runtime-libraries/snippets/System/String/Overview/csharp/index2.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
gewarren
commented
Mar 21, 2025
docs/fundamentals/runtime-libraries/snippets/System/String/Overview/csharp/index11.cs
Outdated
Show resolved
Hide resolved
gewarren
commented
Mar 21, 2025
docs/fundamentals/runtime-libraries/snippets/System/String/Overview/csharp/index2.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #45438.
Internal previews