Skip to content

Conversation

@BartoszKlonowski
Copy link
Contributor

@BartoszKlonowski BartoszKlonowski commented Apr 16, 2025

This pull request fixes #35326
It makes necessary corrections to the mage.exe page such as:

  • removing the misleading statement regarding the -a option with -Sign
  • adding the other now supported options to the -Sign command
    Those newly added are -TimestampUri and -Algorithm. They are mostly copy-paste from the general table, however, I removed "Use with -update option" statement from Algorithm, since I couldn't see that requirement when applying in -Sign context.

Internal previews

📄 File 🔗 Preview link
docs/framework/tools/mage-exe-manifest-generation-and-editing-tool.md Mage.exe (Manifest Generation and Editing Tool)

@BartoszKlonowski BartoszKlonowski requested review from a team and gewarren as code owners April 16, 2025 16:45
@dotnetrepoman dotnetrepoman bot added this to the April 2025 milestone Apr 16, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-framework/svc community-contribution Indicates PR is created by someone from the .NET community. labels Apr 16, 2025
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#35326 states only one algorithm is valid for -Sign.

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@gewarren gewarren enabled auto-merge (squash) April 26, 2025 16:01
@gewarren gewarren merged commit 6753af2 into dotnet:main Apr 26, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-framework/svc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mage.exe: documentation does not detail update Sign command in .NET Framework 4.7.2

2 participants