-
Notifications
You must be signed in to change notification settings - Fork 6k
Add breaking change documentation for CoseSigner.Key property nullability #47740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: gewarren <24882762+gewarren@users.noreply.github.com>
CoseSigner.Key
may now be null
Copilot finished work on behalf of
gewarren
August 5, 2025 23:44
gewarren
approved these changes
Aug 7, 2025
docs/core/compatibility/cryptography/10.0/cosesigner-key-null.md
Outdated
Show resolved
Hide resolved
docs/core/compatibility/cryptography/10.0/cosesigner-key-null.md
Outdated
Show resolved
Hide resolved
docs/core/compatibility/cryptography/10.0/cosesigner-key-null.md
Outdated
Show resolved
Hide resolved
docs/core/compatibility/cryptography/10.0/cosesigner-key-null.md
Outdated
Show resolved
Hide resolved
docs/core/compatibility/cryptography/10.0/cosesigner-key-null.md
Outdated
Show resolved
Hide resolved
docs/core/compatibility/cryptography/10.0/cosesigner-key-null.md
Outdated
Show resolved
Hide resolved
docs/core/compatibility/cryptography/10.0/cosesigner-key-null.md
Outdated
Show resolved
Hide resolved
docs/core/compatibility/cryptography/10.0/cosesigner-key-null.md
Outdated
Show resolved
Hide resolved
gewarren
reviewed
Aug 7, 2025
docs/core/compatibility/cryptography/10.0/cosesigner-key-null.md
Outdated
Show resolved
Hide resolved
gewarren
reviewed
Aug 8, 2025
docs/core/compatibility/cryptography/10.0/cosesigner-key-null.md
Outdated
Show resolved
Hide resolved
PranavSenthilnathan
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for a breaking change in .NET 10 Preview 7 where the
CoseSigner.Key
property may now returnnull
.Changes
The
System.Security.Cryptography.Cose.CoseSigner.Key
property has changed from typeAsymmetricAlgorithm
toAsymmetricAlgorithm?
to support Post-Quantum Cryptography (PQC) algorithms like ML-DSA that don't derive fromAsymmetricAlgorithm
.Previous behavior:
New behavior:
Documentation updates
docs/core/compatibility/cryptography/10.0/cosesigner-key-null.md
- Complete breaking change documentation following the standard templatedocs/core/compatibility/10.0.md
- Added entry to the Cryptography section tabledocs/core/compatibility/toc.yml
- Added navigation entry under Cryptography > .NET 10The documentation explains the reason for the change (support for PQC algorithms), provides clear examples of both old and new behavior, and includes recommended actions for handling null values.
Fixes #46999.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.
Internal previews