Update deploy-with-cli.md #4817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mairaw
modified the milestones:
Sprint 133 (3/17/18 - 4/6/18) ,
Sprint 134 (4/7/2018 - 4/27/2018)
Make the final step of running the application in a framework-depandant deployment part of the overall process. (Addresses some of the complaints in the comments section)
Contributor
|
Sorry for the delay @wattcode. Your PR got caught in the middle of a big change happening in our repo and I now fixed the PR. We'll get that reviewed soon. |
rpetrusha
approved these changes
May 1, 2018
Contributor
rpetrusha
left a comment
rpetrusha
left a comment
There was a problem hiding this comment.
I apologize, @wattcode, that it's taken so long to review your PR. Your changes look good, and I agree that it makes a good deal of sense to list running the application as the final step. I'll merge your PR now. Again, sorry that this has taken so long.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make the final step of running the application in a framework-depandant deployment part of the overall process. (Addresses some of the complaints in the comments section)