System.CommandLine: add notes based on Threat Model review #48184
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gewarren
approved these changes
Sep 4, 2025
| @@ -31,6 +31,8 @@ They are exposed by the <xref:System.CommandLine.ParseResult.Configuration?displ | |||
|
|
|||
| [Response files](syntax.md#response-files) are enabled by default, but you can disable them by setting the <xref:System.CommandLine.ParserConfiguration.ResponseFileTokenReplacer> property to `null`. You can also provide a custom implementation to customize how response files are processed. | |||
|
|
|||
| Response file can contain other response file names, hence parsing may include opening other files. The library expects that all response files were generated and stored by trust worthy agent(s). | |||
There was a problem hiding this comment.
Suggested change
| Response file can contain other response file names, hence parsing may include opening other files. The library expects that all response files were generated and stored by trust worthy agent(s). | |
| Response file can contain other response file names, hence parsing might include opening other files. The library expects that all response files were generated and stored by trustworthy agents. |
| @@ -43,6 +43,8 @@ A token can contain spaces if it's enclosed in quotation marks (`"`). Here's an | |||
| dotnet tool search "ef migrations add" | |||
| ``` | |||
|
|
|||
| The symbol hierarchy (commands, options, arguments) is considered to be trusted input, the token values are not. | |||
There was a problem hiding this comment.
Suggested change
| The symbol hierarchy (commands, options, arguments) is considered to be trusted input, the token values are not. | |
| The symbol hierarchy (commands, options, arguments) is considered to be trusted input; the token values are not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal previews