-
Notifications
You must be signed in to change notification settings - Fork 6k
Update docs (landing page etc) #48189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I imagine the docs crew will want to take a look as well.
Resource Monitoring as a whole is not deprecated. The only part that is deprecated is the particular IResourceMonitor API. Moving it off the main page was just intended to bucket it with other Metrics related information. We don't give any other built-in metrics dedicated space on the overview page so I don't think there is reason to give resource monitoring metrics extra focus. I went ahead and edited the PR description to avoid causing confusion about the state of the resource monitoring feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some mostly style related suggestions.
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Co-authored-by: Noah Falk <noahfalk@users.noreply.github.com>
Summary
These changes mostly affect the landing page of the diagnostics documentation.
Fixes dotnet/diagnostics#3039
Internal previews