Refactor, improve the WebAPIClient tutorial page to use GetFromJsonAsync instead of DeserializeAsync
#48202
+33
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
dotnet-csharp/svc
fundamentals/subsvc
community-contribution
BillWagner
reviewed
Sep 2, 2025
There was a problem hiding this comment.
This looks great @BartoszKlonowski
I had a few comments, and then it's ready to merge.
This reverts commit bb708ac.
This is mentioned in two places - with the C# naming convention, where it's worth to mention why we keep on having uppercase, and in the Repository class defining, where we would normally had to make a conversion, but now we don't because we have case-insensitive method as a tool.
BillWagner
approved these changes
Sep 3, 2025
There was a problem hiding this comment.
This is great @BartoszKlonowski
I'll 
as soon as the build finishes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request closes #47386.
It uses the
System.Net.Http.Json.HttpClientJsonExtensions.GetFromJsonAsyncextension method to simplify the fetching and deserialization process in the tutorial to teach good practices from the beginning and use the latest available features.To achieve the full compatibility with what was there in the tutorial and the new method usage, this PR:
ProcessRepositoriesAsyncfunction to make use of theGetFromJsonAsyncmethod,Repositoryclass so that it doesn't have to use the complicatedJsonPropertyNameofSystem.Text.Json.Serialization, but puts all the class fields that we want to deserialize right away into the class fields,WritetoWriteLine, so that at the beginning, when displaying only the repo name in the console we display it line by line, instead of all together (to slightly improve the readability).I know this displays correctly already in the final page in docs, but it just confused me at first, so wanted to align that with what is displayed in page.
Note
This PR should also have the PR to samples repo merged: dotnet/samples#7067, to make sure that the full, final, project matches the tutorial implementation explained.
Internal previews