Skip to content

Conversation

@Jaxelr
Copy link
Member

@Jaxelr Jaxelr commented Mar 31, 2018

Summary

Added syntax language highlight to dockerfile and console snippets, using as reference the document of Learn Docker Basics with .Net Core.

Added syntax language highlight to code snippets, using as reference the document of Learn Docker Basics with .Net Core.

https://github.com/dotnet/docs/blob/master/docs/core/docker/docker-basics-dotnet-core.md
@BillWagner
Copy link
Member

Ping @DuncanmaMSFT Does the new markdown processor support Dockerfile as a language for triple-back-tick code snippets?

@Duncanma
Copy link
Contributor

Duncanma commented Apr 2, 2018

@BillWagner it does, using either Docker or Dockerfile as the keyword. If it doesn't appear highlighted, we just have to add that language to our build of the highlighter we use. Let me know.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this and making the change @Jaxelr

We appreciate it.

After checking to make sure the dockerfile language was supported by our site team, I'm approving and :shipit: this PR.

You should see the changes show up in the next day or two on our live site.

Thanks again

@BillWagner BillWagner merged commit bc00449 into dotnet:master Apr 2, 2018
@BillWagner BillWagner added this to the Sprint 133 (3/17/18 - 4/06/18) milestone Apr 2, 2018
@Jaxelr Jaxelr deleted the patch-3 branch April 2, 2018 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants