Remove legacy Type Provider content from ToC and update index #4852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dsyme would love a review here as well |
mairaw
reviewed
Apr 2, 2018
| ### [F# Interactive](fsharp/tutorials/fsharp-interactive/index.md) | ||
| ### [Type Providers](fsharp/tutorials/type-providers/index.md) | ||
| #### [Accessing a SQL Database by Using Type Providers](fsharp/tutorials/type-providers/accessing-a-sql-database.md) | ||
| #### [Accessing a SQL Database by Using Type Providers and Entities](fsharp/tutorials/type-providers/accessing-a-sql-database-entities.md) |
There was a problem hiding this comment.
what should happen to these topics that are out of the TOC now?
There was a problem hiding this comment.
I'm personally okay with deleting them, but there are probably some existing links out there which would break if they were deleted. If they're unlinked from the ToC, I would assume that this would give them less SEO weight. But if we still think they'll show up in searches, we should just delete them because they suggest using libraries which are out of date and unmaintained.
There was a problem hiding this comment.
SEO is not based on whether they show up on the TOC or not, so I think you should remove them. Links out there should be redirected to whatever replacement you put for them here.
dsyme
approved these changes
Apr 2, 2018
|
@Rickasaurus FYI if you had any suggestions |
mairaw
approved these changes
Apr 4, 2018
.openpublishing.redirection.json
Outdated
| }, | ||
| { | ||
| "source_path": "docs/fsharp/tutorials/type-providers/accessing-a-sql-database-entities.md", | ||
| "redirect_url": "docs/fsharp/tutorials/type-providers/index.md" |
| Type Providers come in two forms: Generative and Erased. | ||
|
|
||
| Where necessary, you can create your own custom type providers, or reference type providers that have been created by others. For example, assume your organization has a data service providing a large and growing number of named data sets, each with its own stable data schema. You may choose to create a type provider that reads the schemas and presents the latest available data sets to the programmer in a strongly typed way. | ||
| Generative Type Providers produce types which can be written as .NET types into the assembly in which they are produced. This allows them to be consumed from code in other assemblies. This means that the typed representation of the data source must generally be one which is feasible to represent with .NET types. |
There was a problem hiding this comment.
nit: types which -> types that
one which -> one that
| Where necessary, you can create your own custom type providers, or reference type providers that have been created by others. For example, assume your organization has a data service providing a large and growing number of named data sets, each with its own stable data schema. You may choose to create a type provider that reads the schemas and presents the latest available data sets to the programmer in a strongly typed way. | ||
| Generative Type Providers produce types which can be written as .NET types into the assembly in which they are produced. This allows them to be consumed from code in other assemblies. This means that the typed representation of the data source must generally be one which is feasible to represent with .NET types. | ||
|
|
||
| Erasing Type Providers produce types which can only be consumed in the assembly or project they are generated from. The types are ephemeral; that is, they are not written into an assembly and cannot be consumed by code in other assemblies. They can contain *delayed* members, allowing you to use provided types from a potentially infinite information space. They are useful for using a small subset of a large and interconnected data source. |
There was a problem hiding this comment.
nit: types which -> types that
| |[Tutorial: Creating a Type Provider](creating-a-type-provider.md)|Provides information on writing your own custom type providers.| | ||
| |[Type Provider Security](type-provider-security.md)|Provides information about security considerations when developing type providers.| | ||
| |[Troubleshooting Type Providers](troubleshooting-type-providers.md)|Provides information about common problems that can arise when working with type providers and includes suggestions for solutions.| | ||
| - [FSharp.Data](https://fsharp.github.io/FSharp.Data/) includes Type Providers for JSON, XML, CSV and HTML document formats. |
There was a problem hiding this comment.
nit: add comma after CSV (oxford comma)
cartermp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4810. I haven't quite locked down on descriptions and the set of common Type Providers folks should take a look at yet.