Skip to content

Conversation

@pkulikov
Copy link
Contributor

@pkulikov pkulikov commented Apr 5, 2018

This PR is based on two observations:

  • .NET Guide TOC is long and has four entries related to parallel programming.
  • One of those entries is an entry point to other three (not totally correct here, though).

I thought: "Oh, there is an opportunity to compact TOC!" Was it a good thought, or having various parallel-code related topics on one level was intentional?

Additionally

  • Replaced .NET Framework with .NET
  • Recommended TAP instead of EAP in the Threading topic.

@pkulikov pkulikov changed the title .NET standard TOC: combined parallel programming topics .NET Standard TOC: combined parallel programming topics Apr 5, 2018
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for submitting this PR, @pkulikov. You've really done an outstanding job of adding clarity, particularly to the top-level async topic. What I'm a bit concerned about is the TOC -- do developers ordinarily associate parallel processing and concurrency with async? So perhaps the title of the top-level Parallel Processing and Concurrency in .NET topic should be renamed to "Parallel Processing, Concurrency, and Async Programming in .NET" for the title, and "Parallel Processing, Concurrency, and Async" for the TOC. Let me know what you think about that -- I'm fine either with changing it or leaving it as it is in your PR.

@pkulikov
Copy link
Contributor Author

pkulikov commented Apr 6, 2018

@rpetrusha thank you for the remark. I've had the same concern, but was not sure how objective it was. Please check my latest commit with the fix for that. I've also added description meta and updated introduction text, so please review that as well.

Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the additional changes, @pkulikov. This looks extremely good! I'll merge it now. It should be live in the next day or two.

@rpetrusha rpetrusha merged commit 214fd2d into dotnet:master Apr 6, 2018
@pkulikov pkulikov deleted the standard-parallel-restructure branch April 6, 2018 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants