Skip to content

topic fixes #4935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 13, 2018
Merged

topic fixes #4935

merged 4 commits into from
Apr 13, 2018

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Apr 12, 2018

Started working on some updateeachrelease topics and found some issues with the .NET Standard topic not related to the release, so keeping these fixes in a separate PR.

For example, the sample code and the see also links only show up within the VB tab and see also links all show up on a single line.

@mairaw mairaw self-assigned this Apr 12, 2018
@mairaw mairaw requested a review from rpetrusha April 12, 2018 20:48
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good, @mairaw; thanks for making the revisions. Just one nit for you to consider before merging.


The most recent version of the .NET Standard is 2.0. It is included with the .NET Core 2.0 SDK, as well as with Visual Studio 2017 Version 15.3 with the .NET Core workload installed.

## Supported .NET implementations

The .NET Standard 2.0 is supported by the following .NET implementations:
The .NET Standard 2.0 is supported by the following .NET implementations, including later versions of those:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: those -> these
But I wonder if it might not be clearer to append "or later" to each of the implementations in the list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I debated over this myself. I can change that @rpetrusha.

Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems strange, @mairaw -- I approved the PR yesterday.

@rpetrusha
Copy link
Contributor

I'll merge this for you, @mairaw.

@rpetrusha rpetrusha merged commit 2cbd225 into dotnet:master Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants