Update If Then Else (Visual Basic) to improve CSAT #4942

JRAlexander · 2018-04-13T21:59:20Z

If...Then...Else Statement (Visual Basic) API topic has repeated requests for updates. We'll update it, point to the relevant examples, and improve the experience.

Fixes #3505

URL for internal review

JRAlexander · 2018-04-13T22:00:29Z

Closing and reopening - failed build

rpetrusha

I've left a number of comments suggesting additional changes, @JRAlexander.

rpetrusha · 2018-04-13T22:38:31Z

docs/visual-basic/language-reference/statements/if-then-else-statement.md

+
+This article includes several examples that illustrate uses of the `If`...`Then`...`Else`statement:
+
+* [Multiple-line syntax example](#multi-line)


Multiple-line --> Multiline

rpetrusha · 2018-04-13T22:40:42Z

docs/visual-basic/language-reference/statements/if-then-else-statement.md

+
 ## Parts  
 `condition`  
 Required. Expression. Must evaluate to `True` or `False`, or to a data type that is implicitly convertible to `Boolean`.  


On line 65, there should be a space between Nullable and Boolean
if the expression is not True can be easily misread; much better to say "if the expression is `False`
no comma before "the `Else`"

rpetrusha · 2018-04-13T22:41:55Z

docs/visual-basic/language-reference/statements/if-then-else-statement.md

 Optional. One or more statements that are executed if no previous `condition` or `elseifcondition` expression evaluates to `True`.  

 `End If`  
 Terminates the `If`...`Then`...`Else` block.  


Terminates the multiline version of...

rpetrusha · 2018-04-13T22:42:51Z

docs/visual-basic/language-reference/statements/if-then-else-statement.md

+
+

 ## Remarks  


lines 89 and 99 should be level-3 heads, not level-2
line 90: space between True and elseifcondition
line 97: several possible values --> more than three possible values
line 100 doesn't actually say what single-line syntax is: a single condition with code to execute if it's true

rpetrusha · 2018-04-13T22:47:50Z

docs/visual-basic/language-reference/statements/if-then-else-statement.md


 In the single-line syntax, you can have multiple statements executed as the result of an `If`...`Then` decision. All statements must be on the same line and be separated by colons.  

-## Example  


The Example header can't be deleted.

rpetrusha · 2018-04-13T22:49:32Z

docs/visual-basic/language-reference/statements/if-then-else-statement.md

-## Example  
+<a name="multi-line"></a>
+
 The following example illustrates the use of the multiple-line syntax of the `If`...`Then`...`Else` statement.  


multiple-line --> multiline

rpetrusha · 2018-04-13T22:53:20Z

docs/visual-basic/language-reference/statements/if-then-else-statement.md

+
 The following example illustrates the use of the multiple-line syntax of the `If`...`Then`...`Else` statement.  

 [!code-vb[VbVbalrStatements#101](../../../visual-basic/language-reference/error-messages/codesnippet/VisualBasic/if-then-else-statement_1.vb)]  


It might be good here to make this executable -- so wrap it in:

Module Multiline Public Sub Main() Console.WriteLine(message) End Sub End Module

Also, instead of "There are " & count & " items." --> $"There are {count} items." (to use an interpolated string)
And also show output

rpetrusha · 2018-04-13T23:00:43Z

docs/visual-basic/language-reference/statements/if-then-else-statement.md

+
 The following example contains nested `If`...`Then`...`Else` statements.  

 [!code-vb[VbVbalrStatements#102](../../../visual-basic/language-reference/error-messages/codesnippet/VisualBasic/if-then-else-statement_2.vb)]  


It would also be good to wrap this in a Module...End Module statement, include a Main method so it's executable, and add output
The comments also aren't fully accurate. It doesn't test for 2 to 4 PM or noon to 1 PM, but from 2 to 3:59 and 12 to 12:59.

rpetrusha · 2018-04-13T23:02:33Z

docs/visual-basic/language-reference/statements/if-then-else-statement.md

+<a name="single-line"></a>
 The following example illustrates the use of the single-line syntax.  

 [!code-vb[VbVbalrStatements#103](../../../visual-basic/language-reference/error-messages/codesnippet/VisualBasic/if-then-else-statement_3.vb)]  


Here again, this could be a complete code example that's executable. You can use highlighting here (as well as in the other two examples) to focus on the If statements.

JRAlexander · 2018-04-14T05:07:10Z

@rpetrusha I believe I've addressed all your comments. I'm having a bit of an issue with highlighting.

rpetrusha · 2018-04-16T16:58:00Z

The problem with highlighting, @JRAlexander, is that the syntax is incorrect. Instead of
[!code-vb[VbVbalrStatements#101](../../../visual-basic/language-reference/error-messages/codesnippet/VisualBasic/if-then-else-statement_1.vb)]?highlight=10,12,14,16
try
`[!code-vbVbVbalrStatements#101], for example.

JRAlexander · 2018-04-16T18:25:54Z

Got it! Thanks, @rpetrusha! Now I believe I've addressed everything!

rpetrusha

This looks good, @JRAlexander. The one thing that's missing is output from the example, which can be commented-out at the end of the example. It's important to include them here, since the REPL isn't supported yet. Once you add them, you can merge.

mairaw · 2018-04-16T18:55:50Z

docs/visual-basic/language-reference/statements/if-then-else-statement.md

+
+## Quick links to example code
+
+This article includes several examples that illustrate uses of the `If`...`Then`...`Else`statement:


missing space at the end before statement

mairaw · 2018-04-16T18:56:34Z

docs/visual-basic/language-reference/statements/if-then-else-statement.md

+ If the expression is a [Nullable](../../../visual-basic/programming-guide/language-features/data-types/nullable-value-types.md) `Boolean` variable that evaluates to [Nothing](../../../visual-basic/language-reference/nothing.md), the condition is treated as if the expression is `False` and the `Else` block is executed.  

 `Then`  
 Required in the single-line syntax; optional in the multiple-line syntax.  


didn't you change this to multiline?

Missed that.

mairaw · 2018-04-16T18:57:35Z

docs/visual-basic/language-reference/statements/if-then-else-statement.md

-
-## Example  
+
+## Multiline Syntax Example


given that you're completely revisiting the topic, I'd also fix the headings to be sentence case

JRAlexander · 2018-04-16T21:40:43Z

Thank you, @rpetrusha and @mairaw, for your thoughtful comments!

Added Quick links to example code section

1f7264b

JRAlexander added enhancement labels Apr 13, 2018

JRAlexander added this to the Sprint 134 (4/7/2018 - 4/27/2018) milestone Apr 13, 2018

JRAlexander self-assigned this Apr 13, 2018

JRAlexander requested a review from rpetrusha April 13, 2018 21:59

JRAlexander closed this Apr 13, 2018

JRAlexander reopened this Apr 13, 2018

rpetrusha suggested changes Apr 13, 2018

View reviewed changes

jralexander added 2 commits April 13, 2018 23:41

Revised based on review feedback

c1f30fa

Updating code samples

4f87452

jralexander added 4 commits April 16, 2018 12:36

Revising links

4a754f2

Updating Code sample links based on feedback

5405038

revising code sample links

e950be8

Updating highlighting

2e6f79b

rpetrusha approved these changes Apr 16, 2018

View reviewed changes

mairaw reviewed Apr 16, 2018

View reviewed changes

jralexander added 2 commits April 16, 2018 16:02

Updated code comments, changed header case

fe2d3d3

Added Output at end of each sample, updated highlighting

0cfe042

JRAlexander merged commit 725c2b4 into dotnet:master Apr 16, 2018

JRAlexander deleted the vb-if-then-csat branch April 16, 2018 21:41

BillWagner added dotnet-visualbasic/svc and removed 📚 Area - Visual Basic Guide labels Feb 9, 2021


		This article includes several examples that illustrate uses of the `If`...`Then`...`Else`statement:

		* [Multiple-line syntax example](#multi-line)


		In the single-line syntax, you can have multiple statements executed as the result of an `If`...`Then` decision. All statements must be on the same line and be separated by colons.

		## Example


		The following example illustrates the use of the multiple-line syntax of the `If`...`Then`...`Else` statement.

		[!code-vb[VbVbalrStatements#101](../../../visual-basic/language-reference/error-messages/codesnippet/VisualBasic/if-then-else-statement_1.vb)]


		The following example contains nested `If`...`Then`...`Else` statements.

		[!code-vb[VbVbalrStatements#102](../../../visual-basic/language-reference/error-messages/codesnippet/VisualBasic/if-then-else-statement_2.vb)]


		## Quick links to example code

		This article includes several examples that illustrate uses of the `If`...`Then`...`Else`statement:

Update If Then Else (Visual Basic) to improve CSAT #4942

Update If Then Else (Visual Basic) to improve CSAT #4942

Uh oh!

Conversation

JRAlexander commented Apr 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JRAlexander commented Apr 13, 2018

Uh oh!

rpetrusha left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JRAlexander commented Apr 14, 2018

Uh oh!

rpetrusha commented Apr 16, 2018

Uh oh!

JRAlexander commented Apr 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rpetrusha left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JRAlexander commented Apr 16, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JRAlexander commented Apr 13, 2018 •

edited

Loading

JRAlexander commented Apr 16, 2018 •

edited

Loading