Skip to content

Replace broken snippet files #5011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2018
Merged

Replace broken snippet files #5011

merged 2 commits into from
Apr 24, 2018

Conversation

@mairaw
Copy link
Contributor

@mairaw mairaw commented Apr 24, 2018

Related to #5007

@mairaw mairaw self-assigned this Apr 24, 2018
@mairaw mairaw requested a review from rpetrusha April 24, 2018 05:23
@mairaw mairaw mentioned this pull request Apr 24, 2018
Closed
rpetrusha
rpetrusha approved these changes Apr 24, 2018
View reviewed changes
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, @mairaw. I had no idea that these fragmented code files had a meaningful equivalent in the samples repo. You can merge when you're ready.

@mairaw
Copy link
Contributor Author

mairaw commented Apr 24, 2018

They do and we have a branch here with the path to samples “almost” correct. I think I’ll fix a few per day until we’re out of these broken snippets.

@mairaw mairaw merged commit 2bf6485 into dotnet:master Apr 24, 2018
@mairaw mairaw deleted the move-sample branch April 24, 2018 15:48
@mairaw
Copy link
Contributor Author

mairaw commented Apr 24, 2018

Related to #1255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mairaw mairaw

Labels

None yet

Projects

None yet

Milestone

Sprint 134 (4/7/2018 - 4/27/2018)

Development

Successfully merging this pull request may close these issues.

2 participants

@mairaw @rpetrusha