Skip to content

Removed comment from migration topic #5016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2018
Merged

Removed comment from migration topic #5016

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0281c9d
Removed comment from migration topic
Apr 24, 2018
99a715c
Addressed review comment
Apr 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...on-guide/retargeting/wpf/nullreferenceexception-exception-handling-code-from.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

| | |
|---|---|
|Details|An error in the exception handling code for <xref:System.Windows.Media.ImageSourceConverter.ConvertFrom(System.ComponentModel.ITypeDescriptorContext,System.Globalization.CultureInfo,System.Object)> caused an incorrect <xref:System.NullReferenceException?displayProperty=name> to be thrown instead of the intended exception (e.g. <xref:System.IO.DirectoryNotFoundException?displayProperty=name>, <xref:System.IO.FileNotFoundException?displayProperty=name>), this change corrects that error so that the method now throws the right exception.By default all applications targeting .NET Framework 4.6.2 and below will continue to throw <xref:System.NullReferenceException?displayProperty=name> for compatibility, developers targeting .NET Framework 4.7 and above should see the right exceptions.// Replace the space with an 'x' if applicable|
|Suggestion|Developers who wish to revert to getting <xref:System.NullReferenceException?displayProperty=name> when targeting .NET Framework 4.7 can add/merge the following to their application's App.config file:<pre><code class="language-xml">&lt;configuration&gt;&#13;&#10;&lt;runtime&gt;&#13;&#10;&lt;AppContextSwitchOverrides value=&quot;Switch.System.Windows.Media.ImageSourceConverter.OverrideExceptionWithNullReferenceException=true&quot;/&gt;&#13;&#10;&lt;/runtime&gt;&#13;&#10;&lt;/configuration&gt;&#13;&#10;</code></pre>|
|Details|An error in the exception handling code for <xref:System.Windows.Media.ImageSourceConverter.ConvertFrom(System.ComponentModel.ITypeDescriptorContext,System.Globalization.CultureInfo,System.Object)> caused an incorrect <xref:System.NullReferenceException?displayProperty=name> to be thrown instead of the intended exception (<xref:System.IO.DirectoryNotFoundException?displayProperty=name> or <xref:System.IO.FileNotFoundException?displayProperty=name>). This change corrects that error so that the method now throws the right exception. By default all applications targeting .NET Framework 4.6.2 and below will continue to throw <xref:System.NullReferenceException?displayProperty=name> for compatibility, developers targeting .NET Framework 4.7 and above should see the right exceptions.|
|Suggestion|Developers who wish to revert to getting <xref:System.NullReferenceException?displayProperty=name> when targeting .NET Framework 4.7 or later can add/merge the following to their application's App.config file:<pre><code class="language-xml">&lt;configuration&gt;&#13;&#10;&lt;runtime&gt;&#13;&#10;&lt;AppContextSwitchOverrides value=&quot;Switch.System.Windows.Media.ImageSourceConverter.OverrideExceptionWithNullReferenceException=true&quot;/&gt;&#13;&#10;&lt;/runtime&gt;&#13;&#10;&lt;/configuration&gt;&#13;&#10;</code></pre>|
|Scope|Edge|
|Version|4.7|
|Type|Retargeting|
Expand Down