Skip to content

Conversation

@OpportunityLiu
Copy link
Contributor

The guid is for the hash algorithm, not the file;
And the example checksum_bytes is not "an even number of hexadecimal digits".

see : https://github.com/dotnet/roslyn/blob/master/src/Compilers/Core/Portable/PEWriter/DebugSourceInfo.cs
https://github.com/dotnet/roslyn/blob/master/src/Compilers/CSharp/Test/Emit/PDB/CheckSumTest.cs

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this and fixing it @OpportunityLiu We appreciate it.

I've reviewed the changes, and I'll :shipit: now. You should see the changes on the live site in the next day or two, on our regular publishing cycle.

Thanks again for your first contribution to .NET Docs!

@BillWagner BillWagner merged commit 4328718 into dotnet:master Apr 27, 2018
@OpportunityLiu OpportunityLiu deleted the patch-1 branch April 28, 2018 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants