Skip to content

Conversation

@mairaw
Copy link
Contributor

@mairaw mairaw commented May 1, 2018

Moving common metadata settings to the docfx.json file

Related to #5062

@mairaw mairaw added the P0 label May 1, 2018
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @mairaw.

@mairaw
Copy link
Contributor Author

mairaw commented May 1, 2018

Thanks @rpetrusha. @BillWagner do you wanna take a look at this before I merge?

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @mairaw

Let's :shipit:

@mairaw mairaw merged commit 611a8aa into dotnet:master May 1, 2018
@mairaw mairaw deleted the metadata-global branch May 1, 2018 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants