C18342: Missing asterisk on target version #5469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, @rpetrusha, Localization team has reported source content issue that causes issue for localization. We need to escape the asterisk to avoid loc problems. Please review the comment tag added and reply with explanation if fix is needed or not. If you make related fix in another PR then share your PR number so we can confirm and close this PR. Many thanks in advance.
mairaw
requested changes
May 18, 2018
| ``` | ||
|
|
||
| The same rules used to marshal values and references to platform invoke calls are used when marshaling through COM interfaces. For example, when an instance of the `Point` value type is passed from the .NET Framework to COM, the `Point` is passed by value. If the `Point` value type is passed by reference, a pointer to a `Point` is passed on the stack. The interop marshaler does not support higher levels of indirection (**Point \*\***) in either direction. | ||
| The same rules used to marshal values and references to platform invoke calls are used when marshaling through COM interfaces. For example, when an instance of the `Point` value type is passed from the .NET Framework to COM, the `Point` is passed by value. If the `Point` value type is passed by reference, a pointer to a `Point` is passed on the stack. The interop marshaler does not support higher levels of indirection (**Point \***\*) in either direction. |
There was a problem hiding this comment.
This is not rendering correctly. The desired behavior is to have Point **.
So I think that **Point** \*\* would work best.
This is how this is rendering now: 
mairaw
added
Area - .NET Framework Guide
loc
|
Hello, @mairaw, |
rpetrusha
approved these changes
May 21, 2018
There was a problem hiding this comment.
Thanks for opening this PR to correct the formatting issue, @carolinacmoravia. I'll merge your PR now.
|
Sorry, @mairaw. I didn't notice that you'd already reviewed the PR. In any case, @carolinacmoravia addressed the formatting issue. |
mairaw
approved these changes
May 21, 2018
There was a problem hiding this comment.
No worries @rpetrusha. This is good to merge now @carolinacmoravia. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, @rpetrusha,
Localization team has reported source content issue that causes issue for localization. We need to escape the asterisk to avoid loc problems.
Please review the comment tag added and reply with explanation if fix is needed or not. If you make related fix in another PR then share your PR number so we can confirm and close this PR.
Many thanks in advance.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)