Skip to content

Removed repetitive code snippet #5496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2018
Merged

Removed repetitive code snippet #5496

merged 1 commit into from
May 21, 2018

Conversation

@pkulikov
Copy link
Contributor

@pkulikov pkulikov commented May 20, 2018

Removed code snippets are repetitions of the ones presented above in the section and make the section too long without adding value. Also fixed the section heading: H3 -> H2.

@pkulikov pkulikov requested a review from BillWagner as a code owner May 20, 2018 14:49
rpetrusha
rpetrusha approved these changes May 21, 2018
View reviewed changes
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pkulikov, for removing the duplicated code blocks. I'll merge your PR now.

@rpetrusha rpetrusha merged commit 265680a into dotnet:master May 21, 2018
@pkulikov pkulikov deleted the patch-3 branch May 21, 2018 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner Awaiting requested review from BillWagner

1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pkulikov pkulikov

Labels

dotnet-csharp/svc

Projects

None yet

Milestone

Sprint 136 (5/21/18 - 6/8/18)

Development

Successfully merging this pull request may close these issues.

4 participants

@pkulikov @rpetrusha @BillWagner @mairaw