Highlight dependencies which were removed in 2.1 #5569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
janvorli
reviewed
May 23, 2018
| * zlib1g | ||
| * libicu52 (for 14.x) | ||
| * libicu55 (for 16.x) | ||
| * libicu57 (for 17.x) |
Member
There was a problem hiding this comment.
Since you are touching this file, could you please also add libicu60 (for 18.x) here?
JRAlexander
approved these changes
May 24, 2018
Contributor
JRAlexander
left a comment
JRAlexander
left a comment
There was a problem hiding this comment.
LGTM. Thanks, @kasper3, for your contribution! I'll approve this and it should be live in the next few days.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @janvorli's comment: https://github.com/dotnet/coreclr/issues/18097#issuecomment-391457564 and as stated in https://github.com/dotnet/source-build/blob/0648dba/Documentation/boostrap-new-os.md#prerequisites.
Internal Review URL
Edited by: @JRAlexander 05/24/18 - added internal review URL.