Skip to content

Fixed redirects #5595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2018
Merged

Fixed redirects #5595

merged 1 commit into from
May 24, 2018

Conversation

@pkulikov
Copy link
Contributor

@pkulikov pkulikov commented May 24, 2018

Since values of redirect_url are attached to https://docs.microsoft.com, they must start with /dotnet for the pages in this repo.

rpetrusha
rpetrusha approved these changes May 24, 2018
View reviewed changes
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing and fixing the bad redirects, @pkulikov. I'll merge your PR now.

@rpetrusha rpetrusha merged commit 102a82f into dotnet:master May 24, 2018
@pkulikov pkulikov deleted the patch-1 branch May 24, 2018 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pkulikov pkulikov

Labels

None yet

Projects

None yet

Milestone

Sprint 136 (5/21/18 - 6/8/18)

Development

Successfully merging this pull request may close these issues.

3 participants

@pkulikov @rpetrusha @mairaw