-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Surface Forwarded Headers in Docker topic #5764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
FYI: Couple of warnings popped up that don't pertain to this PR. docs/core/additional-tools/dotnet-svcutil-guide.md docs/core/additional-tools/dotnet-svcutil-guide.md docs/framework/wcf/samples/custom-lifetime.md |
|
Thanks, @guardrex! I'll review today. |
|
I have a community PR on this same topic. As soon as that merges, I'll add this. |
|
@JRAlexander Side-note of possible interest: Since the |
|
@guardrex - Did you settle on final language? |
|
Not really. It's all still in a bit of flux on dotnet/AspNetCore.Docs#6538. However, what I propose on this PR is still valid from an ASP.NET Core perspective. We're still pushing Forwarded Headers Middleware for proxied apps, and the linked topic on this PR is the place to go to get that info. I'm not a Docker cat, so I can't say if there are hidden gotchas, but at least this will get a reader here over to the right topic that should in theory get the scheme, IP, port, and host forwarded for a containerized app. |
|
Makes sense to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks,@guardrex, for your contribution. I';ll merge this and you should see it live in a day or two.
@JRAlexander This patch suggestion came about because a community member, @nrandell, didn't see our topic that pertains to the use of Forwarded Headers Middleware for a containerized app.
We have a link to the topic, Configure ASP.NET Core to work with proxy servers and load balancers, on our Docker index page in the ASP.NET Core docs, but that wasn't enough to surface the existence of the topic.
Please feel free to close this, move it, hack it ... I'm guessing a bit that this would be a good spot. I placed it immediately before the first experience walk-through.
Cross-ref: AzureAD/microsoft-authentication-library-for-dotnet#556
Internal Review Topic
cc/ @jmprieur @Rick-Anderson @scottaddie
Thanks to @nrandell for surfacing the problem. 🚀