Skip to content

Conversation

@guardrex
Copy link
Contributor

@guardrex guardrex commented Jun 2, 2018

@JRAlexander This patch suggestion came about because a community member, @nrandell, didn't see our topic that pertains to the use of Forwarded Headers Middleware for a containerized app.

We have a link to the topic, Configure ASP.NET Core to work with proxy servers and load balancers, on our Docker index page in the ASP.NET Core docs, but that wasn't enough to surface the existence of the topic.

Please feel free to close this, move it, hack it ... I'm guessing a bit that this would be a good spot. I placed it immediately before the first experience walk-through.

Cross-ref: AzureAD/microsoft-authentication-library-for-dotnet#556

Internal Review Topic

cc/ @jmprieur @Rick-Anderson @scottaddie

Thanks to @nrandell for surfacing the problem. 🚀

@guardrex guardrex requested a review from JRAlexander as a code owner June 2, 2018 13:23
@guardrex
Copy link
Contributor Author

guardrex commented Jun 2, 2018

FYI: Couple of warnings popped up that don't pertain to this PR.

docs/core/additional-tools/dotnet-svcutil-guide.md
Invalid file link:(~/docs/framework/wcf/servicemodel-metadata-utility-tool-svcutil-exe)

docs/core/additional-tools/dotnet-svcutil-guide.md
Invalid file link:(~/docs/core/additional-tools/wcf-web-service-reference-guide)

docs/framework/wcf/samples/custom-lifetime.md
1 invalid cross reference(s) "xref:System.ServiceModel.Dispatcher.IShareableInstanceContextLifetime"

@JRAlexander
Copy link
Contributor

Thanks, @guardrex! I'll review today.

@JRAlexander
Copy link
Contributor

I have a community PR on this same topic. As soon as that merges, I'll add this.

@guardrex
Copy link
Contributor Author

guardrex commented Jun 5, 2018

@JRAlexander Side-note of possible interest: Since the dotnet new templates configure HTTPS Redirection Middleware, we're going to surface that devs can't expect an OOB template app to run on an unconfigured (for HTTPS) host. We're still working on final language: dotnet/AspNetCore.Docs#6886

@JRAlexander
Copy link
Contributor

@guardrex - Did you settle on final language?

@JRAlexander JRAlexander added the WIP label Jul 9, 2018
@guardrex
Copy link
Contributor Author

guardrex commented Jul 9, 2018

Not really. It's all still in a bit of flux on dotnet/AspNetCore.Docs#6538.

However, what I propose on this PR is still valid from an ASP.NET Core perspective. We're still pushing Forwarded Headers Middleware for proxied apps, and the linked topic on this PR is the place to go to get that info.

I'm not a Docker cat, so I can't say if there are hidden gotchas, but at least this will get a reader here over to the right topic that should in theory get the scheme, IP, port, and host forwarded for a containerized app.

@JRAlexander
Copy link
Contributor

Makes sense to me.

@JRAlexander JRAlexander removed the WIP label Jul 10, 2018
Copy link
Contributor

@JRAlexander JRAlexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks,@guardrex, for your contribution. I';ll merge this and you should see it live in a day or two.

@JRAlexander JRAlexander merged commit b2848fa into dotnet:master Jul 10, 2018
@guardrex guardrex deleted the patch-1 branch July 10, 2018 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants