document null wrt pattern matching #5868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fix typo (exp => expr)
BillWagner
added
the
✨ 1st-time docs contributor!
BillWagner
requested changes
Jun 8, 2018
There was a problem hiding this comment.
Thanks for adding this clarifying remark @IanKemp IT was not clear that the expression cannot be null for the is expression to be true. I did have a suggestion for a different location for the remark. Can you make that change, and then I'll 
.
Thanks for helping us improve docs.
| - *expr* is an instance of a type that implements the *type* interface. | ||
|
|
||
| If *exp* is `true` and `is` is used with an `if` statement, *varname* is assigned and has local scope within the `if` statement only. | ||
| - *expr* does not evaluate to `null`. |
There was a problem hiding this comment.
I'll suggest moving this to Line 72, above. Then, Line 72 would read
The
isexpression istrueif expr does not evaluate tonull, and any of the following is true:
(By putting "expr does not evaluate to null" as one of the conditions in the list, any non-null object would mean is evaluates to true)
The condition "expr is not null" should not be part of the "any of the following" condition.
BillWagner
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fix typo (exp => expr)