Add "enable_uhf_ppe" feature flag to docfx.json. #5919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR enables the feature flag to use the new UHF. See the work item here (https://ceapex.visualstudio.com/Engineering/UX%20Team/_backlogs/board/Stories) and the related feature ticket here (https://ceapex.visualstudio.com/Engineering/UX%20Team/_workitems/edit/18194). This change can be merged into master for testing on our review site. The feature is not live yet so this merge would have no effect on production presentation.
BillWagner
changed the title
|
Add "WIP" to title. |
|
It seems this should be merged @BillWagner. |
|
Hey @BillWagner, I see a note that you have an offline question, but I didn't see any notification of this. I'm not sure if something slipped through the cracks (I didn't see anything in my email, in Teams, or in the VSTS ticket). I hope I didn't miss anything from you. If you resend, I can address this. Thanks! |
|
@jeahyoun I just resent the email. |
|
@BillWagner @mairaw @jeahyoun any open questions here? We've shipped our code and we'd like to start the test. |
|
I don't have any concerns. When ready to merge, just remove the "WIP" label. We'll merge and see how that looks on the master branch on review. If there are no issues, we'll push live. |
adkinn
changed the title
|
@BillWagner done and thanks! |
now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables the feature flag to use the new UHF. See the work item here (https://ceapex.visualstudio.com/Engineering/UX%20Team/_backlogs/board/Stories) and the related feature ticket here (https://ceapex.visualstudio.com/Engineering/UX%20Team/_workitems/edit/18194).
This change can be merged into master for testing on our review site. The feature is not live yet so this merge would have no effect on production presentation.
Internal review site
edit by @BillWagner: Add internal review link