Skip to content

Conversation

@rpetrusha
Copy link
Contributor

@rpetrusha rpetrusha commented Jun 13, 2018

Added information on CNG support in mage.exe

Internal review link: Mage.exe (Manifet Generation and Editing Tool

//cc @Tanya-Solyanik

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the text but with some comments left to be addressed.

## New and Update Command Options
The following table shows the options supported by the `-New` and `-Update` commands.

The following table shows the options supported by the `-New` and `-Update` commands.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: end with :

|**-appc, -AppCodeBase** `manifestReference`||Deployment manifests.|Inserts a URL or file path reference to the application manifest file. This value must be the full path to the application manifest.|
|**-appm, -AppManifest** `manifestPath`||Deployment manifests.|Inserts a reference to a deployment's application manifest into its deployment manifest.<br /><br /> The file indicated by `manifestPath` must exist, or Mage.exe will issue an error. If the file referenced by `manifestPath` is not an application manifest, Mage.exe will issue an error.|
|**-cf, -CertFile** `filePath`||All file types.|Specifies the location of an X509 digital certificate for signing a manifest. This option can be used in conjunction with the **-Password** option, if the certificate requires a password.|
|**-cf, -CertFile** `filePath`||All file types.|Specifies the location of an X509 digital certificate for signing a manifest. This option can be used in conjunction with the **-Password** option if the certificate requires a password.<br/><br/>Starting with the .Net Framework 4.6.2 SDK, which is distributed with Visual Studio and with Windows SDK, mage.exe signs manifests with CNG as well as CAPI certificates.|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.Net -> .NET
italicize mage.exe
remove extra spaces between with and CNG
Can't you download the SDK separately as well?

@rpetrusha rpetrusha merged commit 4775a2b into dotnet:master Jun 14, 2018
@rpetrusha rpetrusha deleted the cng branch June 14, 2018 16:15
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants