-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Added information on CNG support in mage.exe #5943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mairaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the text but with some comments left to be addressed.
| ## New and Update Command Options | ||
| The following table shows the options supported by the `-New` and `-Update` commands. | ||
|
|
||
| The following table shows the options supported by the `-New` and `-Update` commands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: end with :
| |**-appc, -AppCodeBase** `manifestReference`||Deployment manifests.|Inserts a URL or file path reference to the application manifest file. This value must be the full path to the application manifest.| | ||
| |**-appm, -AppManifest** `manifestPath`||Deployment manifests.|Inserts a reference to a deployment's application manifest into its deployment manifest.<br /><br /> The file indicated by `manifestPath` must exist, or Mage.exe will issue an error. If the file referenced by `manifestPath` is not an application manifest, Mage.exe will issue an error.| | ||
| |**-cf, -CertFile** `filePath`||All file types.|Specifies the location of an X509 digital certificate for signing a manifest. This option can be used in conjunction with the **-Password** option, if the certificate requires a password.| | ||
| |**-cf, -CertFile** `filePath`||All file types.|Specifies the location of an X509 digital certificate for signing a manifest. This option can be used in conjunction with the **-Password** option if the certificate requires a password.<br/><br/>Starting with the .Net Framework 4.6.2 SDK, which is distributed with Visual Studio and with Windows SDK, mage.exe signs manifests with CNG as well as CAPI certificates.| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.Net -> .NET
italicize mage.exe
remove extra spaces between with and CNG
Can't you download the SDK separately as well?
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Added information on CNG support in mage.exe
Internal review link: Mage.exe (Manifet Generation and Editing Tool
//cc @Tanya-Solyanik