Removed unsupported configuration attributes #5958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mairaw
approved these changes
Jun 15, 2018
Contributor
mairaw
left a comment
mairaw
left a comment
There was a problem hiding this comment.
From a text perspective, changes look good but left a few comments for you. But this needs a review from the product team before merging.
| |`useDefaultCredentials` or <xref:System.Net.WebProxy.UseDefaultCredentials>|Controls whether the system uses the default network credentials to access a proxy.| | ||
| |`useDefaultCredentialForScriptDownload`|Controls whether the system uses the default network credentials to download the configuration script.| | ||
| |`usesystemdefaults`|Controls whether the static proxy settings (proxy address, bypass list, and bypass on local) should be read from the Internet Explorer proxy settings for the user. If this value is set to "true", then the static proxy settings from Internet Explorer will be used.<br /><br /> If this value is "false" or not set, then the static proxy settings can be specified in the configuration and will override the Internet Explorer proxy settings. This value must also be set to "false" or not set for adaptive proxies to be enabled.| | ||
| You can use the `usesystemdefault` attribute of the [`<proxy>`](../configure-apps/file-schema/network/proxy-element-network-settings.md) element in your configuration file. The `usesystemdefault` attribute controls whether the static proxy settings (proxy address, bypass list, and bypass on local) should be read from the Internet Explorer proxy settings for the user. If this value is set to `true`, the static proxy settings from Internet Explorer will be used. If this value is `false` or not set, the static proxy settings can be specified in the configuration and will override the Internet Explorer proxy settings. This value must also be set to `false` or not set for adaptive proxies to be enabled.| |
Contributor
There was a problem hiding this comment.
nit: did you mean to have that pipe at the end?
| |`bypassonlocal` or <xref:System.Net.WebProxy.BypassProxyOnLocal>|Controls whether the proxy is bypassed for local addresses.| | ||
| |`bypasslist` or <xref:System.Net.WebProxy.BypassArrayList>|Describes, with regular expressions, a set of addresses that bypass the proxy.| | ||
| |`usesystemdefaults`|Controls whether the static proxy settings (proxy address, bypass list, and bypass on local) should be read from the Internet Explorer proxy settings for the user. If this value is set to "true", then the static proxy settings from Internet Explorer will be used. On .NET Framework 2.0 when this value is set to "true", the Internet Explorer proxy settings are not overridden by other proxy settings in the configuration file. On .NET Framework 1.1, the Internet Explorer proxy settings can be overridden by other proxy settings in the configuration file.<br /><br /> If this value is "false" or not set, then the static proxy settings can be specified in the configuration and will override the Internet Explorer proxy settings. This value must also be set to "false" or not set for adaptive proxies to be enabled.| | ||
| |`usesystemdefaults`|Controls whether the static proxy settings (proxy address, bypass list, and bypass on local) should be read from the Internet Explorer proxy settings for the user. If this value is set to `true`, then the static proxy settings from Internet Explorer will be used. On .NET Framework 2.0 when this value is set to `true`, the Internet Explorer proxy settings are not overridden by other proxy settings in the configuration file. On .NET Framework 1.1, the Internet Explorer proxy settings can be overridden by other proxy settings in the configuration file.<br /><br /> If this value is `false` or not set, then the static proxy settings can be specified in the configuration and will override the Internet Explorer proxy settings. This value must also be set to `false` or not set for adaptive proxies to be enabled.| |
Contributor
There was a problem hiding this comment.
why are we talking about .NET 2.0 and 1.1 only here?
Contributor
There was a problem hiding this comment.
On .NET Framework 2.0 when this value is set to
true, the Internet Explorer proxy settings are not overridden by other proxy settings in the configuration file. On .NET Framework 1.1, the Internet Explorer proxy settings can be overridden by other proxy settings in the configuration file.
I would delete the above sentences.
added 2 commits
June 18, 2018 10:18
BillWagner
added
dotnet-framework/svc
networking/subsvc
and removed
📚 Area - .NET Framework Guide
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unsupported configuration attributes
@davidsh, I've just removed the unsupported attributes. Would you mind taking a closer look at the topic, though? In addition, the description for
usesystemdefaultsays that it must be set to false to enable an adaptive proxy, but the "typical adaptive proxy" example sets it to true. Should it be set to false, or is the description inaccurate?