Skip to content

Conversation

@rpetrusha
Copy link
Contributor

Fixed bad FWLink

In addition to fixing the link described in #6056, this PR:

  • replaces tokens with simple token text.
  • fences Win32 APIs and constants and adds links to them.

Fixes #6056

@mairaw
Copy link
Contributor

mairaw commented Jun 21, 2018

For this kind of broken link report we've been getting, I try to first find the sample under https://github.com/Microsoft/WPF-Samples. If I can't find it, I'm linking to the location of the sample in our samples repo and also updating the FwLink in case an external resource is also using the same link.

The problem of linking to that vs.90 page is that the download sample link is dead there too.

@mairaw
Copy link
Contributor

mairaw commented Jun 21, 2018

It seems the sample exissts under https://github.com/Microsoft/WPF-Samples/tree/master/Migration%20and%20Interoperability/WPFHostingWin32Control not sure though if the docs match that.

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpetrusha rpetrusha merged commit 7d81dc8 into dotnet:master Jun 21, 2018
@rpetrusha rpetrusha deleted the wpf-link branch June 21, 2018 19:36
@mairaw mairaw removed this from the Sprint 137 (06/11/18 - 06/29/18) milestone Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link to sample code is dead

2 participants