Remove empty sections #6126
Remove empty sections #6126
Conversation
| } | ||
| ``` | ||
|
|
||
| ## Compiling the code |
There was a problem hiding this comment.
This section can also be deleted, References are to assemblies, not namespaces; importing the System,.Net namespace is handled by the using statement. No types in the System.Net assembly are used.
| } | ||
| ``` | ||
|
|
||
| ## Compiling the code |
There was a problem hiding this comment.
Same comment as previously: this section can be deleted.
| } | ||
| ``` | ||
|
|
||
| ## Compiling the code |
There was a problem hiding this comment.
This section can be removed.
| using System; | ||
| using System.IO; | ||
| using System.Net; | ||
| using System.Text; |
There was a problem hiding this comment.
the using System.Text; statement is not needed and can be deleted.
| using System; | ||
| using System.IO; | ||
| using System.Net; | ||
| using System.Text; |
There was a problem hiding this comment.
the using System.Text; statement is not needed and can be deleted.
|
@rpetrusha thanks for your thorough review. I wasn't much looking at the content inside the sections. Since we were improving the topics, I also added the VB version of those. Do you wanna double check? |
| ``` | ||
|
|
||
| ```vb | ||
| Imports System |
There was a problem hiding this comment.
Imports System isn't necessary; it's automatically imported by the compiler.
| Imports System.Net | ||
|
|
||
| Namespace Examples.System.Net | ||
| Public Class WebRequestGetExample |
There was a problem hiding this comment.
It's typical to do this as a module (Public Module WebRequestGetExample)
|
|
||
| Namespace Examples.System.Net | ||
| Public Class WebRequestGetExample | ||
| Public Shared Sub Main() |
There was a problem hiding this comment.
If this becomes a module, the signature becomes Public Sub Main()
| reader.Close() | ||
| response.Close() | ||
| End Sub | ||
| End Class |
| } | ||
| ``` | ||
|
|
||
| ```vb |
There was a problem hiding this comment.
Same comments as previously: System does not need to be imported, and a Module is better Irequiring a change to the Main method signature as well).
| ``` | ||
|
|
||
| ```vb | ||
| Imports System |
There was a problem hiding this comment.
Same comments here as for previous examples.
| StreamReader reader = new StreamReader(responseStream); | ||
| Console.WriteLine(reader.ReadToEnd()); | ||
|
|
||
| Console.WriteLine("Download Complete, status {0}", response.StatusDescription); |
There was a problem hiding this comment.
These Console.WriteLine statements with composite formatting strings could be done as interpolated strings in C# and VB if you'd like to make the changes. Here, `Console.WriteLine($"Download Complete, status {response.StatusDescription}");
There was a problem hiding this comment.
are we adding notes about C# version needed when adding interpolated strings?
There was a problem hiding this comment.
Sorry, @mairaw. I missed your question. No, we haven't been, other than in the C# and VB interpolated string docs themselves.
|
Appreciate your comments @rpetrusha. I believe all the feedback is now addressed. |
2 participants
Fixes #6118 - found a few more topics with the same issue
Hide whitespace changes for a better diff