Skip to content

Conversation

@mairaw
Copy link
Contributor

@mairaw mairaw commented Jun 26, 2018

Related to #1255

Hide whitespace changes for easier diff

@mairaw mairaw self-assigned this Jun 26, 2018
@mairaw mairaw requested a review from BillWagner as a code owner June 26, 2018 07:49
@mairaw mairaw changed the title remove inner snippet remove inner snippets Jun 26, 2018
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @mairaw

I had a couple small notes unrelated to this PR that you can address if you want.

enum Day : byte {Sat=1, Sun, Mon, Tue, Wed, Thu, Fri};
```

The approved types for an enum are [byte](../../../csharp/language-reference/keywords/byte.md), [sbyte](../../../csharp/language-reference/keywords/sbyte.md), [short](../../../csharp/language-reference/keywords/short.md), [ushort](../../../csharp/language-reference/keywords/ushort.md), [int](../../../csharp/language-reference/keywords/int.md), [uint](../../../csharp/language-reference/keywords/uint.md), [long](../../../csharp/language-reference/keywords/long.md), or [ulong](../../../csharp/language-reference/keywords/ulong.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to this PR: I've been shrinking the paths for simplicity (../../../csharp/language-reference/keywords/byte.md) becomes (byte.md)


```c
// cmdll.c
// Compile with: /LD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to your PR: We've been trying to use the '-' for options instead of '/' for platform independence.

@mairaw mairaw merged commit dd49baa into dotnet:master Jun 26, 2018
@mairaw mairaw deleted the move-sample2 branch June 26, 2018 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants