C26886: Misuse of ` character to create codeboxes #6200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, @mairaw , Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version. "this bug is affected by a source issue by the ´ character used to create codeboxes" Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR then share your PR number so we can confirm and close this PR. Many thanks in advance.
rpetrusha
suggested changes
Jun 28, 2018
|
|
||
| - The <xref:System.ServiceModel.Channels.CommunicationObject> class implements <xref:System.ServiceModel.ICommunicationObject> and enforces the state machine previously described in Step 2. | ||
|
|
||
| - The``<xref:System.ServiceModel.Channels.ChannelManagerBase> class implements <xref:System.ServiceModel.Channels.CommunicationObject> and provides a unified base class for <xref:System.ServiceModel.Channels.ChannelFactoryBase> and <xref:System.ServiceModel.Channels.ChannelListenerBase>. The <xref:System.ServiceModel.Channels.ChannelManagerBase> class works in conjunction with <xref:System.ServiceModel.Channels.ChannelBase>, which is a base class that implements <xref:System.ServiceModel.Channels.IChannel>. |
Contributor
There was a problem hiding this comment.
The `` before <xref:System.ServiceModel.Channels.ChannelManagerBase> should also be removed.
| - The``<xref:System.ServiceModel.Channels.ChannelManagerBase> class implements <xref:System.ServiceModel.Channels.CommunicationObject> and provides a unified base class for <xref:System.ServiceModel.Channels.ChannelFactoryBase> and <xref:System.ServiceModel.Channels.ChannelListenerBase>. The <xref:System.ServiceModel.Channels.ChannelManagerBase> class works in conjunction with <xref:System.ServiceModel.Channels.ChannelBase>, which is a base class that implements <xref:System.ServiceModel.Channels.IChannel>. | ||
|
|
||
| - The``<xref:System.ServiceModel.Channels.ChannelFactoryBase> class implements <xref:System.ServiceModel.Channels.ChannelManagerBase> and <xref:System.ServiceModel.Channels.IChannelFactory> and consolidates the `CreateChannel` overloads into one `OnCreateChannel` abstract method. | ||
| - The `<xref:System.ServiceModel.Channels.ChannelFactoryBase>` class implements `<xref:System.ServiceModel.Channels.ChannelManagerBase>` and `<xref:System.ServiceModel.Channels.IChannelFactory>` and consolidates the `CreateChannel` overloads into one `OnCreateChannel` abstract method. |
Contributor
There was a problem hiding this comment.
The fix here is to remove ``, not to replace it with a single `. This should be, "The <xref:System.ServiceModel.Channels.ChannelFactoryBase> class implements <xref:..."
|
|
||
| ### The UdpChannelListener | ||
| The``UdpChannelListener that the sample implements derives from the <xref:System.ServiceModel.Channels.ChannelListenerBase> class. It uses a single UDP socket to receive datagrams. The `OnOpen` method receives data using the UDP socket in an asynchronous loop. The data are then converted into messages using the Message Encoding Framework. | ||
| The `UdpChannelListener` that the sample implements derives from the `<xref:System.ServiceModel.Channels.ChannelListenerBase>` class. It uses a single UDP socket to receive datagrams. The `OnOpen` method receives data using the UDP socket in an asynchronous loop. The data are then converted into messages using the Message Encoding Framework. |
Contributor
There was a problem hiding this comment.
` and ` should be removed from <xref:System.ServiceModel.Channgels.ChannelListenerBase>
| ``` | ||
|
|
||
| Because the same datagram channel represents messages that arrive from a number of sources, the `UdpChannelListener` is a singleton listener. There is, at most, one active <xref:System.ServiceModel.Channels.IChannel>``associated with this listener at a time. The sample generates another one only if a channel that is returned by the `AcceptChannel` method is subsequently disposed. When a message is received, it is enqueued into this singleton channel. | ||
| Because the same datagram channel represents messages that arrive from a number of sources, the `UdpChannelListener` is a singleton listener. There is, at most, one active `<xref:System.ServiceModel.Channels.IChannel>` associated with this listener at a time. The sample generates another one only if a channel that is returned by the `AcceptChannel` method is subsequently disposed. When a message is received, it is enqueued into this singleton channel. |
Contributor
There was a problem hiding this comment.
remove ` and ` from <xref:System.ServiceModel.Channels.IChannel>
mairaw
added
the
loc
Contributor
|
@rpetrusha I took care of your comments to speed up the process. |
Contributor
Author
|
Thanks both @rpetrusha and @mairaw . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, @mairaw ,
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
"this bug is affected by a source issue by the ´ character used to create codeboxes"
Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR then share your PR number so we can confirm and close this PR.
Many thanks in advance.