-
Notifications
You must be signed in to change notification settings - Fork 6.1k
C26917: Misuse of ´ to create codeboxes at line 179 #6220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, @mairaw, Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version. "this bug is affected by a source issue by the ´ used to create codeboxes" Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR then share your PR number so we can confirm and close this PR. Many thanks in advance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@v-maudel The original text was a mistake. However, the fix you've proposed has other issues. Once you've addressed that comment, I'll ![]()
|
|
||
| #### Policy Export | ||
| The `UdpTransportBindingElement` type implements``<xref:System.ServiceModel.Description.IPolicyExportExtension?displayProperty=nameWithType> to add support for exporting policy. As a result, <xref:System.ServiceModel.Description.MetadataExporter?displayProperty=nameWithType> includes `UdpTransportBindingElement` in the generation of policy for any binding that includes it. | ||
| The `UdpTransportBindingElement` type implements `<xref:System.ServiceModel.Description.IPolicyExportExtension?displayProperty=nameWithType>` to add support for exporting policy. As a result, `<xref:System.ServiceModel.Description.MetadataExporter?displayProperty=nameWithType>` includes `UdpTransportBindingElement` in the generation of policy for any binding that includes it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The correct fix would be to remove the code fence character on all the xrefs. The xref will style the element correctly.
|
Thanks so much for the notice @BillWagner , |
|
#sign-off |
|
Hi @BillWagner , It seems I can't merge it automatically, could you please do it for me or maybe indicate if these changes will be made in another PR? Thanks. |
|
@v-maudel I'll merge. I was just waiting for build to finish. |
|
Thanks @BillWagner . |
Hello, @mairaw ,
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
"this bug is affected by a source issue by the ´ used to create codeboxes"
Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR then share your PR number so we can confirm and close this PR.
Many thanks in advance.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)