Skip to content

Conversation

@v-maudel
Copy link
Contributor

Hello, @mairaw ,
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
"this bug is affected by a source issue by the ´ used to create codeboxes"

Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR then share your PR number so we can confirm and close this PR.

Many thanks in advance.

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

Hello, @mairaw,
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.  
"this bug is affected by a source issue by the ´ used to create codeboxes"  

Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR  then share your PR number so we can confirm and close this PR.

Many thanks in advance.
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-maudel The original text was a mistake. However, the fix you've proposed has other issues. Once you've addressed that comment, I'll :shipit:


#### Policy Export
The `UdpTransportBindingElement` type implements``<xref:System.ServiceModel.Description.IPolicyExportExtension?displayProperty=nameWithType> to add support for exporting policy. As a result, <xref:System.ServiceModel.Description.MetadataExporter?displayProperty=nameWithType> includes `UdpTransportBindingElement` in the generation of policy for any binding that includes it.
The `UdpTransportBindingElement` type implements `<xref:System.ServiceModel.Description.IPolicyExportExtension?displayProperty=nameWithType>` to add support for exporting policy. As a result, `<xref:System.ServiceModel.Description.MetadataExporter?displayProperty=nameWithType>` includes `UdpTransportBindingElement` in the generation of policy for any binding that includes it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct fix would be to remove the code fence character on all the xrefs. The xref will style the element correctly.

@v-maudel
Copy link
Contributor Author

Thanks so much for the notice @BillWagner ,
I've already updated the file as suggested and will let the production team to know this as well so we don't propose the same change in the future.

@v-maudel
Copy link
Contributor Author

#sign-off

@v-maudel
Copy link
Contributor Author

Hi @BillWagner , It seems I can't merge it automatically, could you please do it for me or maybe indicate if these changes will be made in another PR?

Thanks.

@BillWagner
Copy link
Member

@v-maudel I'll merge. I was just waiting for build to finish.

@BillWagner BillWagner merged commit e04bd64 into dotnet:master Jun 29, 2018
@v-maudel
Copy link
Contributor Author

Thanks @BillWagner .
Didn't want to rush you. :)

@v-maudel v-maudel deleted the patch-5 branch June 29, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants