Skip to content

Conversation

@douglaslMS
Copy link
Contributor

Summary

Corrected an erroneous Note about events raised by opening and closing connections.

Fixes #6217

Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @douglaslMS. The URLs can be relative: /sql/relational-databases/event-classes/audit-login-event-class and /sql/relational-databases/event-classes/audit-logout-event-class., if you'd like to change them. You can merge when you're ready.

@douglaslMS
Copy link
Contributor Author

@rpetrusha I have to add the ".md" if I provide the URLs in that format, don't I?

@rpetrusha
Copy link
Contributor

No, you don't have to add the ".md", @douglaslMS.

@rpetrusha
Copy link
Contributor

Also, the link won't work in the build environment, but it will work in the production environment.

@douglaslMS douglaslMS merged commit 20c4927 into dotnet:master Jul 5, 2018
@douglaslMS douglaslMS deleted the adonet-login-events branch July 5, 2018 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants