Updated description of how to define ref return value #6377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
requested changes
Jul 12, 2018
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
This is a great set of changes @pkulikov
I had two small comments, and then it's ready to merge.
| ```csharp | ||
| public ref Person GetContactInformation(string fname, string lname); | ||
| ``` | ||
| - the method signature includes the [ref](../../language-reference/keywords/ref.md) keyword in front of the return type, |
Member
There was a problem hiding this comment.
I think this would be better shown as an unordered list.
Contributor
Author
There was a problem hiding this comment.
Isn't it already unordered @BillWagner? Or it should be numbered?
Member
There was a problem hiding this comment.
Ahh. 👀 weren't seeing the '-' earlier.
Then, just two very small nits: Each should be a sentence, so period after "return type" in the first, instead of a comma, and capitalize "The" and "Each".
Contributor
Author
There was a problem hiding this comment.
Updated! Thank you for review.
| - each [return](../../language-reference/keywords/return.md) statement in the method body includes the [ref](../../language-reference/keywords/ref.md) keyword in front of the name of the returned instance. | ||
|
|
||
| In addition, the name of the object returned by each [return](../../language-reference/keywords/return.md) statement in the method body must be preceded by the [ref](../../language-reference/keywords/ref.md) keyword. For example, the following `return` statement returns a reference to a `Person` object named `p`: | ||
| The following example shows the method that satisfies those conditions and returns a reference to a `Person` object named `p`: |
Member
There was a problem hiding this comment.
I would change "the method" to "a method"
BillWagner
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated description of conditions and the example.
Fixes #6369