Skip to content

Conversation

@Thraka
Copy link
Contributor

@Thraka Thraka commented Jul 9, 2018

Summary

Added a note about how the bypassonlocal attribute kills the scriptlocation attribute.

Fixes #6112

@Thraka Thraka self-assigned this Jul 9, 2018
@Thraka Thraka requested a review from rpetrusha July 9, 2018 18:59
@mairaw mairaw requested a review from davidsh July 9, 2018 23:39
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @Thraka. I just left one comment.

The value for the `proxyaddress` attribute should be a well-formed Uniform Resource Indicator (URI).

The `scriptLocation` attribute refers to the automatic detection of proxy configuration scripts. The <xref:System.Net.WebProxy> class will attempt to locate a configuration script (usually named Wpad.dat) when the **Use automatic configuration script** option is selected in Internet Explorer.
The `scriptLocation` attribute refers to the automatic detection of proxy configuration scripts. The <xref:System.Net.WebProxy> class will attempt to locate a configuration script (usually named Wpad.dat) when the **Use automatic configuration script** option is selected in Internet Explorer. If `bypassonlocal` is set to any value, `scriptLocation` will be ignored.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: will be --> is

@Thraka Thraka merged commit d805336 into master Jul 10, 2018
@mairaw mairaw deleted the adegeo-6112 branch July 14, 2018 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants