Skip to content

Conversation

@mairaw
Copy link
Contributor

@mairaw mairaw commented Jul 11, 2018

Based on PR #6413, decided to see if there were more double backtick issues in our repo. This is the first set of fixes.

@mairaw mairaw self-assigned this Jul 11, 2018
@mairaw mairaw requested a review from rpetrusha as a code owner July 11, 2018 21:57
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @mairaw. I've left two comments that are unrelated to your PR.

7. Add a top-level menu item to the `Form2`<xref:System.Windows.Forms.MenuStrip> and set its <xref:System.Windows.Forms.ToolStripItem.Text%2A> property to `&File`.

8. Add submenu items to the `&File` menu of `Form2` in the following order: a <xref:System.Windows.Forms.ToolStripSeparator>, `&Save`, `&Close``and Save`, and another <xref:System.Windows.Forms.ToolStripSeparator>.
8. Add submenu items to the `&File` menu of `Form2` in the following order: a <xref:System.Windows.Forms.ToolStripSeparator>, `&Save`, `&Close` and `Save`, and another <xref:System.Windows.Forms.ToolStripSeparator>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated to your PR: There are two Save menu items and three items total. Based on the table that follows this, there should be just two total items: `&Save` and `Save and &Close`.

- Using the Clipboard's `GetData` or `SetData` method with a Clipboard format other than `vbCFBitmap`, `vbCFDIB`, or `vbCFMetafile`.

- Using the `DataObject``GetData` method or `SetData` method with a Clipboard format in the range reserved by Microsoft Windows for registered formats (&HC000-&HFFFF), when that Clipboard format has not been registered with Microsoft Windows.
- Using the `DataObject` `GetData` method or `SetData` method with a Clipboard format in the range reserved by Microsoft Windows for registered formats (&HC000-&HFFFF), when that Clipboard format has not been registered with Microsoft Windows.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit unrelated to your PR: this is awkward. Perhaps, "Using the `GetData` or `SetData` methods of a \DataObject\"?

@mairaw mairaw merged commit f42ca4d into dotnet:master Jul 12, 2018
@mairaw mairaw deleted the issues branch July 12, 2018 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants