Skip to content

Conversation

@mairaw
Copy link
Contributor

@mairaw mairaw commented Jul 13, 2018

Related to #1255

Noticed in PR #6336 that we were making code fixes to the inner snippets. Let's avoid that. Work with me to first remove the call to the inner snippet and point to the dotnet/samples, then make the changes.

Hide whitespace changes for easier diff

Related PR: dotnet/samples#174

@mairaw mairaw added WIP 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) labels Jul 13, 2018
@mairaw mairaw self-assigned this Jul 13, 2018
@mairaw mairaw requested a review from BillWagner as a code owner July 13, 2018 02:15
@mairaw mairaw removed the WIP label Jul 13, 2018
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

I'll approve it, and added the hold for related PR (which I also approved).

Once the build is clean, :shipit:

@mairaw mairaw closed this Jul 13, 2018
@mairaw mairaw reopened this Jul 13, 2018
@mairaw mairaw merged commit e6528df into dotnet:master Jul 13, 2018
@mairaw mairaw deleted the move-sample5 branch July 13, 2018 18:03
@mairaw mairaw removed the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants