Improved article about non-CLS exceptions #6451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpetrusha
suggested changes
Jul 13, 2018
| - Within a `catch (Exception e)` block as a <xref:System.Runtime.CompilerServices.RuntimeWrappedException>. | ||
| - Within a `catch (RuntimeWrappedException e)` block. | ||
|
|
||
| By default, a Visual C# assembly catches non-CLS exceptions as wrapped exceptions. Use this method if you need access to the original exception, which can be accessed through the <xref:System.Runtime.CompilerServices.RuntimeWrappedException.WrappedException%2A> property. The procedure later in this topic explains how to catch exceptions in this manner. |
There was a problem hiding this comment.
unrelated to your PR: add ?displayProperty=nameWithType to <xref:System.Runtime.CompilerServices.RuntimeWrappedException.WrappedException%2A>. I think that the other two occurrences of WrappedException might be clearer with ?displayProperty=nameWithType as well.
| try | ||
| { | ||
| The following example shows how to catch a non-CLS exception that was thrown from a class library written in C++/CLI. Note that in this example, the C# client code knows in advance that the exception type being thrown is a <xref:System.String?displayProperty=nameWithType>. You can cast the <xref:System.Runtime.CompilerServices.RuntimeWrappedException.WrappedException%2A> property back its original type as long as that type is accessible from your code. |
There was a problem hiding this comment.
Great catch for C++/CLR --> C++/CLI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6446.
Changes I made:
catch (Exception ex)and then testing forRuntimeWrappedException, just usecatch (RuntimeWrappedException e). It's simpler and I don't see any reason not to do it this way.