Skip to content

Fix broken link #6516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Fix broken link #6516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...container-microservice-net-applications/background-tasks-with-ihostedservice.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,9 +250,7 @@ The `IHostedService` interface provides a convenient way to start background tas

- **ASP.NET Core 2.1 Hosting samples**

[*https://github.com/aspnet/Hosting/tree/dev/samples/GenericHostSample*](https://github.com/aspnet/Hosting/tree/dev/samples/GenericHostSample)


[*https://github.com/aspnet/Hosting/tree/release/2.1/samples/GenericHostSample*](https://github.com/aspnet/Hosting/tree/release/2.1/samples/GenericHostSample)
Copy link
Contributor

@natemcmaster natemcmaster Jul 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend using a canonical link instead. This original link was broken because we deleted the dev branch. We might delete release/2.1 at some point.

https://github.com/aspnet/Hosting/tree/1596c2ba5508fceefd929228b4e5e95e50b1d4d4/samples/GenericHostSample

Copy link
Contributor Author

@mairaw mairaw Jul 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a pretty ugly URL to show to customers given the whole URL is printed in these e-books 😄

If you get to the point of deleting that branch, it would probably be time for reviewing this topic no?

Copy link
Contributor

@natemcmaster natemcmaster Jul 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly, but we're never going to remember to do that when/if we delete branches. It may be better to just copy that sample into the docs instead of relying on it existing on GitHub.

Or, use a url shortener that produces a less-ugly URL.

Copy link
Contributor Author

@mairaw mairaw Jul 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be on us to run broken link tests and not on you. If the target looks fine, I'll keep it as is. We're trying to avoid url shorteners as much as possible, since the community cannot edit them.


>[!div class="step-by-step"]
[Previous](test-aspnet-core-services-web-apps.md)
Expand Down