Skip to content

Noted finalizer not called on shutdown on .NET Core #6540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2018
Merged

Noted finalizer not called on shutdown on .NET Core #6540

merged 1 commit into from
Jul 19, 2018

Conversation

@rpetrusha
Copy link
Contributor

@rpetrusha rpetrusha commented Jul 18, 2018 •
edited
Loading

Noted finalizer not called on shutdown on .NET Core

//cc @jkotas

Fixes #5974

See also dotnet/dotnet-api-docs#363

@rpetrusha rpetrusha requested a review from BillWagner as a code owner July 18, 2018 23:13
@rpetrusha rpetrusha mentioned this pull request Jul 18, 2018
Merged
BillWagner
BillWagner approved these changes Jul 19, 2018
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @rpetrusha

You can :shipit: when ready.

@rpetrusha rpetrusha merged commit 57a6b42 into dotnet:master Jul 19, 2018
@rpetrusha rpetrusha deleted the finalize branch July 26, 2018 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

@jkotas jkotas jkotas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rpetrusha @BillWagner @jkotas